-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 44.0.0 release: version and changelog #13882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@@ -44,6 +44,7 @@ def generate_changelog(repo, repo_name, tag1, tag2, version): | |||
unique_pulls = [] | |||
all_pulls = [] | |||
for commit in comparison.commits: | |||
print(".", file=sys.stderr, end=" ", flush=True) # progress indicator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sorry I should have commented on that one -- it is due to the fact I am on a relatively slow internet connection and it wasn't clear to me the script was actually doing anything without this feedback.
Thank you @phillipleblanc and @goldmedal I am waiting on the final ticket required for the 44 release: Then I will update the changelog with the most recent commits, merge this PR and make a release candidate |
Which issue does this PR close?
44.0.0
#13334Rationale for this change
Prepare for the release
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?