Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc-gen: migrate scalar functions (string) documentation 1/4 #13924

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Chen-Yuan-Lai
Copy link
Contributor

@Chen-Yuan-Lai Chen-Yuan-Lai commented Dec 27, 2024

Which issue does this PR close?

Part of #13671 .

Rationale for this change

What changes are included in this PR?

As discussed in #13671 , this PR will migrate the parts of builtin string functions documentation that currently support migration.

Are these changes tested?

Are there any user-facing changes?

@Omega359
Copy link
Contributor

I believe you may have forgotten to run the doc generation script prior to pushing this change

@Chen-Yuan-Lai
Copy link
Contributor Author

Chen-Yuan-Lai commented Dec 28, 2024

@Omega359 Yes 😢 I'll run doc generation script for other PRs all together. Thanks for reviewing 🙏

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 29, 2024
Comment on lines 855 to 857
```sql
trim(trim_str FROM str)
```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@comphead I found that use_doc() only supports one alternative syntax. Should we modify it to support multiple alternative syntaxes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants