-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support explain query when running dfbench with clickbench #13942
Conversation
cc @alamb It's a small change for explain support for dfbench, thanks! |
Perhaps we can use an existing common option to print plans datafusion/benchmarks/src/util/options.rs Line 40 in ab69bb0
tpch benchmark uses this flag, but it's not used in clickbench yet datafusion/benchmarks/src/tpch/run.rs Lines 194 to 232 in ab69bb0
|
Thank you @2010YOUY01 for review and good suggestion! Addressed in latest PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @zhuqi-lucas and @2010YOUY01 -- looks good to me
FYI @XiangpengHao as I think you have also been using this benchmark program
Which issue does this PR close?
Closes #13941
Rationale for this change
What changes are included in this PR?
Add the debug option for clickbench
Are these changes tested?
yes:
Are there any user-facing changes?
yes