Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example in the DataFrame documentation. #7650

Merged

Conversation

jsimpson-gro
Copy link
Contributor

In the documentation for DataFrame, a copy/paste of the example has a couple of compile errors.

.show returns a Future, and the Future returns a Result.

Which issue does this PR close?

Closes #7649.

Rationale for this change

Make it easier to use the example.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

In the [documentation for DataFrame](https://arrow.apache.org/datafusion/user-guide/dataframe.html), a copy/paste of the example has a couple
of compile errors.

`.show` returns a `Future`, and the `Future` returns a `Result`.
@alamb
Copy link
Contributor

alamb commented Sep 25, 2023

Thank you @jsimpson-gro 🙏

@alamb alamb merged commit 44575a8 into apache:main Sep 25, 2023
Ted-Jiang pushed a commit to Ted-Jiang/arrow-datafusion that referenced this pull request Oct 7, 2023
In the [documentation for DataFrame](https://arrow.apache.org/datafusion/user-guide/dataframe.html), a copy/paste of the example has a couple
of compile errors.

`.show` returns a `Future`, and the `Future` returns a `Result`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example in the DataFrame documentation has two minor syntax issues.
2 participants