Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add compile check for SchemaScanner #45797

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wangbo
Copy link
Contributor

@wangbo wangbo commented Dec 23, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wangbo
Copy link
Contributor Author

wangbo commented Dec 23, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.89% (10132/26056)
Line Coverage: 29.81% (85258/286039)
Region Coverage: 28.93% (43537/150483)
Branch Coverage: 25.46% (22188/87164)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2d8edf1dfbc54d20d7ca847629f51e2fb62cb343_2d8edf1dfbc54d20d7ca847629f51e2fb62cb343/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 40073 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2d8edf1dfbc54d20d7ca847629f51e2fb62cb343, data reload: false

------ Round 1 ----------------------------------
q1	17568	7672	7354	7354
q2	2054	173	169	169
q3	10618	1111	1170	1111
q4	10573	730	815	730
q5	7603	2803	2659	2659
q6	237	149	148	148
q7	986	626	600	600
q8	9451	1887	1910	1887
q9	6652	6397	6514	6397
q10	7064	2326	2332	2326
q11	483	273	269	269
q12	427	226	219	219
q13	17783	3015	3010	3010
q14	246	207	209	207
q15	575	493	490	490
q16	676	581	586	581
q17	1019	491	477	477
q18	7362	6733	6888	6733
q19	1356	995	943	943
q20	466	181	176	176
q21	3998	3308	3274	3274
q22	378	313	322	313
Total cold run time: 107575 ms
Total hot run time: 40073 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7332	7243	7253	7243
q2	335	232	233	232
q3	2936	2944	3011	2944
q4	2097	1891	1922	1891
q5	5674	5670	5728	5670
q6	236	148	149	148
q7	2243	1827	1839	1827
q8	3433	3529	3596	3529
q9	8874	8984	9006	8984
q10	3617	3555	3565	3555
q11	607	502	519	502
q12	786	614	605	605
q13	12207	3235	3173	3173
q14	328	284	266	266
q15	554	515	506	506
q16	685	642	636	636
q17	1902	1661	1608	1608
q18	8401	7865	7870	7865
q19	1725	1615	1564	1564
q20	2181	1889	1942	1889
q21	5644	5516	5585	5516
q22	650	560	612	560
Total cold run time: 72447 ms
Total hot run time: 60713 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197055 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2d8edf1dfbc54d20d7ca847629f51e2fb62cb343, data reload: false

query1	1295	951	918	918
query2	6253	2423	2384	2384
query3	10932	4682	4706	4682
query4	33197	23371	23291	23291
query5	4394	477	472	472
query6	281	204	206	204
query7	3988	311	314	311
query8	319	249	255	249
query9	9557	2757	2768	2757
query10	475	254	250	250
query11	18015	15081	15078	15078
query12	162	103	101	101
query13	1588	427	414	414
query14	10268	7046	8105	7046
query15	303	190	206	190
query16	8111	430	489	430
query17	1833	571	584	571
query18	2216	312	321	312
query19	369	164	189	164
query20	129	117	116	116
query21	211	116	105	105
query22	4787	4469	4437	4437
query23	35444	33916	33724	33724
query24	10363	2703	2542	2542
query25	590	401	403	401
query26	724	157	150	150
query27	2610	346	338	338
query28	6281	2509	2495	2495
query29	755	412	422	412
query30	237	154	149	149
query31	1024	840	852	840
query32	95	57	59	57
query33	722	300	294	294
query34	997	522	534	522
query35	908	755	785	755
query36	1161	948	994	948
query37	121	74	75	74
query38	4286	4150	4285	4150
query39	1493	1492	1527	1492
query40	206	106	103	103
query41	45	42	43	42
query42	116	108	105	105
query43	573	513	518	513
query44	1265	870	826	826
query45	199	171	163	163
query46	1188	739	737	737
query47	2011	1909	1951	1909
query48	437	323	318	318
query49	877	381	399	381
query50	849	402	418	402
query51	7407	7186	7255	7186
query52	103	92	99	92
query53	259	184	188	184
query54	986	413	418	413
query55	85	83	78	78
query56	282	278	243	243
query57	1314	1196	1145	1145
query58	237	231	228	228
query59	3456	3279	3393	3279
query60	288	243	257	243
query61	112	107	110	107
query62	882	702	681	681
query63	228	200	196	196
query64	3902	697	661	661
query65	3361	3338	3306	3306
query66	753	325	303	303
query67	16438	15611	15420	15420
query68	5678	569	587	569
query69	519	267	265	265
query70	1220	1163	1130	1130
query71	489	249	247	247
query72	7029	4087	4101	4087
query73	804	366	365	365
query74	10325	8860	8851	8851
query75	3841	2662	2669	2662
query76	3863	1111	1142	1111
query77	591	278	298	278
query78	10201	9419	9575	9419
query79	1899	625	599	599
query80	1265	422	416	416
query81	515	232	232	232
query82	386	116	123	116
query83	199	143	140	140
query84	285	71	66	66
query85	1189	305	297	297
query86	397	311	273	273
query87	4554	4488	4487	4487
query88	3403	2307	2232	2232
query89	426	292	282	282
query90	2072	191	182	182
query91	137	106	108	106
query92	63	51	50	50
query93	2283	552	556	552
query94	825	291	320	291
query95	345	253	256	253
query96	621	284	281	281
query97	2829	2682	2615	2615
query98	219	199	201	199
query99	1593	1326	1313	1313
Total cold run time: 304418 ms
Total hot run time: 197055 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.29 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2d8edf1dfbc54d20d7ca847629f51e2fb62cb343, data reload: false

query1	0.04	0.04	0.06
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.10	0.10
query5	0.43	0.41	0.41
query6	1.17	0.66	0.65
query7	0.03	0.01	0.01
query8	0.04	0.04	0.03
query9	0.59	0.48	0.53
query10	0.56	0.56	0.56
query11	0.15	0.10	0.10
query12	0.13	0.11	0.10
query13	0.61	0.62	0.60
query14	2.75	2.72	2.74
query15	0.90	0.82	0.82
query16	0.38	0.38	0.38
query17	1.09	1.06	1.01
query18	0.22	0.21	0.20
query19	1.98	1.84	1.94
query20	0.01	0.01	0.01
query21	15.35	0.59	0.60
query22	3.09	1.96	2.28
query23	17.15	0.93	0.92
query24	3.26	1.11	0.46
query25	0.21	0.12	0.08
query26	0.42	0.14	0.14
query27	0.05	0.05	0.04
query28	10.99	1.11	1.06
query29	12.58	3.27	3.23
query30	0.24	0.06	0.06
query31	2.88	0.38	0.38
query32	3.26	0.49	0.46
query33	3.12	3.11	3.08
query34	16.90	4.49	4.44
query35	4.53	4.46	4.45
query36	0.68	0.49	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.02	0.03
query40	0.17	0.12	0.12
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 108.18 s
Total hot run time: 32.29 s

@wangbo
Copy link
Contributor Author

wangbo commented Dec 23, 2024

run buildall

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 23, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.80% (10094/26015)
Line Coverage: 29.79% (85151/285856)
Region Coverage: 28.91% (43474/150403)
Branch Coverage: 25.44% (22159/87116)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c3f548b5ee3f08b470f64be40aba150263d7bc7f_c3f548b5ee3f08b470f64be40aba150263d7bc7f/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 39580 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c3f548b5ee3f08b470f64be40aba150263d7bc7f, data reload: false

------ Round 1 ----------------------------------
q1	17600	7415	7238	7238
q2	2052	182	163	163
q3	10590	1074	1121	1074
q4	10473	746	767	746
q5	7617	2706	2547	2547
q6	237	151	147	147
q7	983	653	614	614
q8	9240	1859	1961	1859
q9	6520	6430	6397	6397
q10	7016	2316	2312	2312
q11	467	259	260	259
q12	419	229	222	222
q13	17759	2960	2951	2951
q14	254	218	212	212
q15	544	504	496	496
q16	671	586	603	586
q17	973	570	495	495
q18	7215	6743	6575	6575
q19	1347	1054	981	981
q20	476	182	187	182
q21	4069	3216	3209	3209
q22	383	322	315	315
Total cold run time: 106905 ms
Total hot run time: 39580 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7212	7246	7209	7209
q2	325	227	234	227
q3	2908	2778	2905	2778
q4	2041	1775	1730	1730
q5	5649	5628	5959	5628
q6	228	139	145	139
q7	2188	1833	1804	1804
q8	3364	3521	3507	3507
q9	8981	8971	8942	8942
q10	3603	3526	3520	3520
q11	594	496	533	496
q12	822	614	608	608
q13	14651	3059	3105	3059
q14	308	278	278	278
q15	556	500	510	500
q16	703	649	670	649
q17	1827	1615	1569	1569
q18	8339	7763	7592	7592
q19	1791	1567	1555	1555
q20	2061	1916	1860	1860
q21	5584	5402	5402	5402
q22	657	608	604	604
Total cold run time: 74392 ms
Total hot run time: 59656 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196765 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c3f548b5ee3f08b470f64be40aba150263d7bc7f, data reload: false

query1	1292	1010	892	892
query2	6253	2412	2348	2348
query3	11019	4763	4639	4639
query4	33566	23459	23336	23336
query5	4054	472	464	464
query6	293	208	203	203
query7	3986	302	303	302
query8	298	228	239	228
query9	9591	2753	2728	2728
query10	473	243	246	243
query11	17625	15138	15065	15065
query12	162	108	99	99
query13	1571	417	412	412
query14	8663	7881	7333	7333
query15	311	212	209	209
query16	8365	441	508	441
query17	1690	611	626	611
query18	2182	333	325	325
query19	366	165	189	165
query20	124	110	114	110
query21	221	131	113	113
query22	4777	4522	4590	4522
query23	35863	33854	33493	33493
query24	10464	2594	2453	2453
query25	569	396	393	393
query26	1141	160	163	160
query27	3068	341	338	338
query28	7546	2482	2504	2482
query29	703	414	431	414
query30	235	152	155	152
query31	1014	860	833	833
query32	104	54	60	54
query33	781	298	292	292
query34	1145	534	548	534
query35	934	759	768	759
query36	1127	960	966	960
query37	133	77	75	75
query38	4356	4206	4147	4147
query39	1516	1485	1468	1468
query40	258	101	104	101
query41	45	46	44	44
query42	115	104	102	102
query43	552	497	507	497
query44	1331	835	822	822
query45	193	169	168	168
query46	1184	750	761	750
query47	1994	1922	1949	1922
query48	415	324	336	324
query49	891	406	385	385
query50	832	417	395	395
query51	7325	7331	7158	7158
query52	107	89	88	88
query53	262	192	191	191
query54	1193	431	457	431
query55	82	82	84	82
query56	266	248	242	242
query57	1286	1177	1144	1144
query58	232	220	224	220
query59	3464	3316	3421	3316
query60	279	246	268	246
query61	106	103	111	103
query62	869	695	697	695
query63	223	194	216	194
query64	3931	707	657	657
query65	3334	3251	3262	3251
query66	843	295	311	295
query67	16226	15612	15493	15493
query68	6360	560	559	559
query69	500	274	253	253
query70	1156	1162	1092	1092
query71	524	260	266	260
query72	6423	4010	4134	4010
query73	792	366	368	366
query74	10191	8763	8809	8763
query75	4130	2644	2644	2644
query76	3915	1120	1179	1120
query77	668	273	280	273
query78	10353	9287	9382	9287
query79	1111	607	605	605
query80	800	421	432	421
query81	519	224	229	224
query82	222	119	116	116
query83	198	148	164	148
query84	287	76	156	76
query85	1003	310	296	296
query86	351	293	307	293
query87	4617	4548	4472	4472
query88	3553	2234	2202	2202
query89	420	292	289	289
query90	2142	187	189	187
query91	139	103	103	103
query92	60	51	51	51
query93	1331	548	548	548
query94	900	280	292	280
query95	349	266	258	258
query96	608	278	285	278
query97	2807	2682	2676	2676
query98	221	198	196	196
query99	1569	1350	1308	1308
Total cold run time: 303638 ms
Total hot run time: 196765 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.89 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c3f548b5ee3f08b470f64be40aba150263d7bc7f, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.08	0.07
query4	1.60	0.11	0.10
query5	0.43	0.41	0.40
query6	1.16	0.66	0.67
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.58	0.50	0.53
query10	0.55	0.54	0.56
query11	0.14	0.11	0.11
query12	0.14	0.11	0.12
query13	0.61	0.63	0.59
query14	2.74	2.86	2.84
query15	0.89	0.82	0.83
query16	0.38	0.38	0.40
query17	1.05	1.00	1.03
query18	0.23	0.22	0.23
query19	1.95	1.89	1.99
query20	0.01	0.01	0.01
query21	15.36	0.59	0.58
query22	2.81	2.36	1.93
query23	17.03	1.04	0.87
query24	3.10	0.89	2.19
query25	0.26	0.09	0.19
query26	0.38	0.13	0.14
query27	0.04	0.04	0.06
query28	9.88	1.11	1.07
query29	12.56	3.30	3.30
query30	0.25	0.07	0.06
query31	2.86	0.39	0.38
query32	3.27	0.48	0.47
query33	3.07	3.05	3.15
query34	16.90	4.45	4.49
query35	4.48	4.44	4.49
query36	0.71	0.50	0.49
query37	0.09	0.06	0.05
query38	0.04	0.04	0.04
query39	0.03	0.03	0.03
query40	0.17	0.13	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.03
query43	0.04	0.03	0.02
Total cold run time: 106.31 s
Total hot run time: 32.89 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants