Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](TrinoConnector) fix the error message when querying a not-existent table with TrinoConnector #45799

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BePPPower
Copy link
Contributor

@BePPPower BePPPower commented Dec 23, 2024

Problem Summary:
fix the error message when querying a not-existent table with TrinoConnector

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BePPPower
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40057 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 267eea3fb8dff2aef15520546cb9ba23072aa0a2, data reload: false

------ Round 1 ----------------------------------
q1	17620	7426	7341	7341
q2	2046	179	178	178
q3	10602	1066	1218	1066
q4	10572	758	716	716
q5	7596	2711	2668	2668
q6	243	154	151	151
q7	992	632	607	607
q8	9255	1848	1948	1848
q9	6618	6435	6441	6435
q10	7026	2321	2335	2321
q11	459	258	260	258
q12	431	219	224	219
q13	17985	2979	3001	2979
q14	242	212	208	208
q15	550	502	500	500
q16	669	607	587	587
q17	998	550	561	550
q18	7216	6685	6710	6685
q19	1347	1009	976	976
q20	486	183	184	183
q21	4082	3330	3269	3269
q22	377	315	312	312
Total cold run time: 107412 ms
Total hot run time: 40057 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7275	7156	7248	7156
q2	324	229	235	229
q3	2883	2809	2996	2809
q4	2098	1873	1852	1852
q5	5675	5655	5631	5631
q6	236	150	148	148
q7	2193	1811	1815	1811
q8	3417	3541	3548	3541
q9	8933	9063	8947	8947
q10	3599	3497	3578	3497
q11	599	519	499	499
q12	819	646	594	594
q13	12578	3151	3133	3133
q14	314	269	269	269
q15	554	500	507	500
q16	701	651	622	622
q17	1838	1633	1598	1598
q18	8249	7851	7694	7694
q19	1744	1624	1591	1591
q20	2093	1807	1949	1807
q21	5607	5365	5435	5365
q22	634	597	578	578
Total cold run time: 72363 ms
Total hot run time: 59871 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197559 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 267eea3fb8dff2aef15520546cb9ba23072aa0a2, data reload: false

query1	1292	990	948	948
query2	6229	2402	2404	2402
query3	11152	4820	4838	4820
query4	33254	23487	23321	23321
query5	4165	465	456	456
query6	264	189	184	184
query7	4000	300	301	300
query8	306	241	242	241
query9	9563	2762	2768	2762
query10	484	245	240	240
query11	17822	15053	15131	15053
query12	159	100	100	100
query13	1554	421	413	413
query14	8441	7780	7940	7780
query15	318	209	205	205
query16	8180	477	515	477
query17	1701	641	587	587
query18	2060	331	304	304
query19	381	159	160	159
query20	122	113	110	110
query21	213	107	109	107
query22	4765	4414	4466	4414
query23	36350	33738	33710	33710
query24	10341	2627	2487	2487
query25	517	404	394	394
query26	730	163	156	156
query27	2244	343	341	341
query28	7683	2482	2483	2482
query29	659	412	435	412
query30	233	155	150	150
query31	1035	875	843	843
query32	102	62	61	61
query33	756	334	314	314
query34	973	542	524	524
query35	886	766	795	766
query36	1109	964	974	964
query37	133	80	83	80
query38	4218	4121	4371	4121
query39	1544	1454	1450	1450
query40	221	109	101	101
query41	47	46	45	45
query42	117	104	104	104
query43	548	523	519	519
query44	1266	844	843	843
query45	191	170	177	170
query46	1177	721	708	708
query47	2034	1922	1910	1910
query48	430	331	326	326
query49	946	424	393	393
query50	841	402	408	402
query51	7308	7131	7227	7131
query52	110	95	97	95
query53	267	192	198	192
query54	1138	417	435	417
query55	82	77	83	77
query56	258	247	254	247
query57	1236	1150	1168	1150
query58	228	212	219	212
query59	3348	3260	3291	3260
query60	276	254	268	254
query61	105	114	108	108
query62	867	722	695	695
query63	221	192	200	192
query64	3915	684	654	654
query65	3286	3239	3285	3239
query66	1044	327	308	308
query67	16487	15624	15516	15516
query68	5235	554	545	545
query69	502	259	246	246
query70	1201	1161	1125	1125
query71	458	276	246	246
query72	6385	4134	4046	4046
query73	797	363	378	363
query74	10077	8933	8847	8847
query75	3467	2827	2678	2678
query76	3722	1144	1104	1104
query77	571	288	300	288
query78	10202	9280	9404	9280
query79	1635	603	602	602
query80	1207	430	444	430
query81	506	225	221	221
query82	652	120	118	118
query83	200	160	144	144
query84	279	70	71	70
query85	1304	308	294	294
query86	386	306	291	291
query87	4730	4436	4364	4364
query88	3401	2264	2228	2228
query89	435	292	294	292
query90	1930	192	192	192
query91	143	112	108	108
query92	69	51	52	51
query93	2266	554	546	546
query94	780	289	284	284
query95	342	246	250	246
query96	638	284	282	282
query97	2870	2676	2631	2631
query98	220	197	195	195
query99	1662	1335	1296	1296
Total cold run time: 302204 ms
Total hot run time: 197559 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.23 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 267eea3fb8dff2aef15520546cb9ba23072aa0a2, data reload: false

query1	0.04	0.04	0.05
query2	0.07	0.03	0.04
query3	0.24	0.07	0.07
query4	1.62	0.10	0.10
query5	0.41	0.42	0.40
query6	1.14	0.65	0.64
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.58	0.51	0.51
query10	0.57	0.56	0.56
query11	0.14	0.10	0.11
query12	0.14	0.12	0.11
query13	0.62	0.61	0.59
query14	2.78	2.74	2.85
query15	0.90	0.82	0.82
query16	0.35	0.38	0.37
query17	0.98	1.05	1.03
query18	0.23	0.21	0.21
query19	1.99	1.85	1.97
query20	0.02	0.01	0.01
query21	15.37	0.60	0.60
query22	2.48	3.02	1.91
query23	16.85	1.04	0.83
query24	3.57	1.11	2.71
query25	0.16	0.22	0.17
query26	0.61	0.15	0.14
query27	0.04	0.05	0.05
query28	8.84	1.11	1.08
query29	12.61	3.30	3.25
query30	0.25	0.06	0.06
query31	2.86	0.39	0.40
query32	3.23	0.46	0.45
query33	3.14	3.16	3.26
query34	16.98	4.50	4.52
query35	4.54	4.50	4.54
query36	0.66	0.48	0.48
query37	0.10	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.12	0.12
query41	0.08	0.03	0.03
query42	0.04	0.02	0.03
query43	0.03	0.04	0.03
Total cold run time: 105.57 s
Total hot run time: 33.23 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants