Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: remove dubbo protocol impl which replaced by the impl in dubbo-go project #364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wongoo
Copy link
Contributor

@wongoo wongoo commented Jul 20, 2023

What this PR does:
The implementation of dubbo2 rpc protocol in dubbo-go-hessian2 project is deprecated for a long time.

The dubbo team has already maintained the implementation in dubbo-go project instead.

To avoid confusion for users, it's better to remove dubbo protocol impl in dubbo-go-hessian2.

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@wongoo wongoo mentioned this pull request Jul 20, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #364 (53c2f20) into master (f0fbe40) will increase coverage by 2.42%.
The diff coverage is n/a.

❗ Current head 53c2f20 differs from pull request most recent head f862307. Consider uploading reports for the commit f862307 to get more accurate results

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
+ Coverage   68.98%   71.40%   +2.42%     
==========================================
  Files          28       25       -3     
  Lines        3140     2616     -524     
==========================================
- Hits         2166     1868     -298     
+ Misses        751      591     -160     
+ Partials      223      157      -66     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants