Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read remote metadata once during application execution #15006

Open
wants to merge 1 commit into
base: 3.3
Choose a base branch
from

Conversation

finefuture
Copy link
Contributor

@finefuture finefuture commented Dec 20, 2024

What is the purpose of the change?

The local cache file may be damaged for various reasons, resulting in a no provider exception, so I recommend reading the remote metadata once during the application running process.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.77%. Comparing base (a9e4910) to head (dff48ec).

Files with missing lines Patch % Lines
...ubbo/registry/client/AbstractServiceDiscovery.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15006      +/-   ##
============================================
+ Coverage     60.76%   60.77%   +0.01%     
  Complexity    10866    10866              
============================================
  Files          1882     1882              
  Lines         85983    85988       +5     
  Branches      12876    12876              
============================================
+ Hits          52246    52258      +12     
+ Misses        28289    28282       -7     
  Partials       5448     5448              
Flag Coverage Δ
integration-tests 32.99% <83.33%> (-0.15%) ⬇️
samples-tests 29.23% <83.33%> (+<0.01%) ⬆️
unit-tests 58.91% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants