Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types export for nodeNext moduleResolution #20453

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BTMuli
Copy link

@BTMuli BTMuli commented Oct 25, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

[Bug] Typescript setting module to "NodeNext" cannot obtain type prompt #19992

Details

Before: What was the problem?

When use "moduleResolution:nodeNext",it will throw err like Module '"echarts/core"' has no exported member 'init'.

image

After: How does it behave after the fixing?

Refer to the same issue on svelte#5028 and its solve pr,I add types export and it looks well.

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Oct 25, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@throrin19
Copy link

Any news about this ? We have to migrate our project to vue 3 and nodeNext but we are blocked with echarts and this feature....

@BTMuli
Copy link
Author

BTMuli commented Dec 3, 2024

Any news about this ? We have to migrate our project to vue 3 and nodeNext but we are blocked with echarts and this feature....

Nope,without anyone review this simple pr.

You could fork and changg code then publish your own package,otherwise there is no exact time.😓

@BTMuli
Copy link
Author

BTMuli commented Dec 3, 2024

For a more easy way,change the echarts dependency to a file path such as lib/echarts,in which way I use to test this pr if it works well.

@throrin19
Copy link

@BTMuli It works but with that solution we lost types :(

@BTMuli
Copy link
Author

BTMuli commented Dec 4, 2024

@BTMuli It works but with that solution we lost types :(

You should install dependencies and run build script,It works well on my proj.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants