This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Fixes #FINCN-326 Create, update, list tellers and Teller Details implemented #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jawidMuhammadi Please take a look at this PR whenever you get time. |
jawidMuhammadi
suggested changes
Jun 19, 2021
app/src/main/java/org/apache/fineract/ui/online/teller/createteller/TellerReviewStepFragment.kt
Outdated
Show resolved
Hide resolved
|
Awesome job @varsvat, please do the necessary changes as I requested, the remaining parts look good to me. |
|
@therajanmaurya Please review this PR when you get the time and then you can merge it. |
|
@jawidMuhammadi As discussed, Support for Task management features have been Implemented. Kindly review and let me know if any changes are to be done. |
jawidMuhammadi
suggested changes
Jun 25, 2021
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FINCN-326 and FINCN-327
Creating, Editing, updating Teller functionality Implemented through MVVM architecture. Teller Details Screen has also been implemented. UI tests for various text fields have also been integrated.
Edit: Support for Task management features have also been extended.
This PR adds support for the following functionalities and improvements:
The UI for all the screens has been tried to keep as similar as possible to maintain uniformity of UI in the app.
Teller_Functionalities_implemented.mp4
Task management features:
Fix.327.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anything.If you have multiple commits please combine them into one commit by squashing them.