-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(java/python): new xlang type system spec implementation #1690
Open
chaokunyang
wants to merge
57
commits into
apache:main
Choose a base branch
from
chaokunyang:new_xlang_sepc_impl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
chaokunyang
added a commit
that referenced
this pull request
Jul 13, 2024
## What does this PR do? This PR moves `org.apache.fury.reflect.Types` into TypeRef. Types is used in Fury type system, by merge `org.apache.fury.reflect.Types`, we can reduce ambiguation in fury type system ## Related issues #1553 #1690 ## Does this PR introduce any user-facing change? <!-- If any user-facing interface changes, please [open an issue](https://github.com/apache/fury/issues/new/choose) describing the need to do so and update the document if necessary. --> - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark <!-- When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here. -->
chaokunyang
force-pushed
the
new_xlang_sepc_impl
branch
from
July 13, 2024 11:41
86a35c3
to
a3d4d9d
Compare
I haven't finish it, this PR mainly reimplement xlang serialization with new protocol. Detailed description will be added in next days. |
chaokunyang
changed the title
feat: new xlang spec impl
feat(java/python): new xlang spec impl
Dec 20, 2024
chaokunyang
changed the title
feat(java/python): new xlang spec impl
feat(java/python): new xlang type system spec implementation
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements a new type system for xlang serialization between java and python.
The changes includes:
ArrayList/Object[]
in java. Users canserialize(List.of(1, 2, ,3))
and deserialize it into array bydeserialize(bytes, Integer[].class)
Related issues
Does this PR introduce any user-facing change?
Benchmark