HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6524

PDavid · 2024-12-09T14:55:52Z

This is the backport of #6490 for branch-2.

As these are not present anymore in v4.

Reason: to make sure that they are the same size (this under thrift was smaller).

This is the latest non-vulnerable version.

- Navbars now require a container within (to drastically simplify spacing requirements and CSS required). - The .active class can no longer be applied to .nav-items, it must be applied directly on .nav-links.

Data attributes for all Bootstrap JavaScript plugins are now namespaced to help distinguish Bootstrap functionality from third parties and your own code. For example, we use data-bs-toggle instead of data-toggle.

Breaking change in Bootstrap 5: Dropped form-specific layout classes for our grid system. Use our grid and utilities instead of .form-group, .form-row, or .form-inline.

to make the UI coloring look similar to what we had before.

to make sure the current active navbar link is highlighted appropriately.

(used by the "Regions in Transition" section on master status page) so that the paginator links are styled and displayed properly.

Before the tab content has its own bottom border and table row also had its own bottom border. This resulted in having two lines in all table boundaries. Fix is to remove the bottom border of the table row.

Make sure background color is visible in tables (Tasks) where alert class is used.

Reverting former change which imported: org.apache.hadoop.hbase.*

So that buttons and textfields are displayed properly. Also removes unneeded inline styles.

Apache-HBase · 2024-12-11T14:52:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 17s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	jshint	0m 0s		jshint was not available.
+0 🆗	shelldocs	0m 1s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 44s		branch-2 passed
+1 💚	compile	6m 11s		branch-2 passed
+1 💚	checkstyle	1m 16s		branch-2 passed
+1 💚	spotbugs	12m 34s		branch-2 passed
+1 💚	spotless	0m 52s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 28s		the patch passed
+1 💚	compile	6m 13s		the patch passed
+1 💚	javac	6m 13s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 15s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	spotbugs	14m 16s		the patch passed
+1 💚	hadoopcheck	24m 19s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚	spotless	1m 17s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	1m 4s		The patch does not generate ASF License warnings.
		81m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6524/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6524
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless jshint shellcheck shelldocs
uname	Linux a5c4b8a9e2bb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `1c6f572`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	178 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6524/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-12-11T22:41:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 52s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 19s		branch-2 passed
+1 💚	compile	2m 51s		branch-2 passed
+1 💚	javadoc	4m 27s		branch-2 passed
+1 💚	shadedjars	6m 14s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 41s		the patch passed
+1 💚	compile	3m 5s		the patch passed
+1 💚	javac	3m 5s		the patch passed
+1 💚	javadoc	3m 50s		the patch passed
+1 💚	shadedjars	7m 27s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	503m 54s	/patch-unit-root.txt	root in the patch failed.
		550m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6524/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6524
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 0c1fad7f7fa4 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `1c6f572`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6524/3/testReport/
Max. process+thread count	5459 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6524/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-12-11T23:06:33Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
-0 ⚠️	yetus	0m 8s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 40s		branch-2 passed
+1 💚	compile	2m 57s		branch-2 passed
+1 💚	javadoc	3m 36s		branch-2 passed
+1 💚	shadedjars	9m 20s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 50s		the patch passed
+1 💚	compile	2m 58s		the patch passed
+1 💚	javac	2m 58s		the patch passed
+1 💚	javadoc	4m 12s		the patch passed
+1 💚	shadedjars	6m 37s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	524m 12s	/patch-unit-root.txt	root in the patch failed.
		575m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6524/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6524
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 6580495f72b8 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `1c6f572`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6524/3/testReport/
Max. process+thread count	5594 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6524/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

PDavid added 18 commits December 9, 2024 11:27

HBASE-28832 Removed bootstrap-theme.min.css and Glyphicons icon font

5f6444b

As these are not present anymore in v4.

HBASE-28832 Upgrade to Bootstrap 4

54da97f

HBASE-28832 Migrated Log Level forms

fe26934

HBASE-28832 Migrated REST web UI pages

e9f5eb0

HBASE-28832 Migrated canary status page navbar

0f25ee3

HBASE-28832 Migrated Thrift UI pages

1a7c391

HBASE-28832 Replaced hbase_logo_small.png with hbase-server one

98a2968

Reason: to make sure that they are the same size (this under thrift was smaller).

HBASE-28832 Upgraded Bootstrap to 5.3.3

d3e7d8e

This is the latest non-vulnerable version.

HBASE-28832 Migrated navbars

a5bd475

- Navbars now require a container within (to drastically simplify spacing requirements and CSS required). - The .active class can no longer be applied to .nav-items, it must be applied directly on .nav-links.

HBASE-28832 Migrated data attributes

59edf54

Data attributes for all Bootstrap JavaScript plugins are now namespaced to help distinguish Bootstrap functionality from third parties and your own code. For example, we use data-bs-toggle instead of data-toggle.

HBASE-28832 Migrated inline forms - Log levels, table.jsp

05d59ba

Breaking change in Bootstrap 5: Dropped form-specific layout classes for our grid system. Use our grid and utilities instead of .form-group, .form-row, or .form-inline.

HBASE-28832 Fixed checkstyle warnings

051e439

HBASE-28832 Preserve original HBase UI colors

b6572d9

to make the UI coloring look similar to what we had before.

HBASE-28832 Restore active navbar link background-color

88791d1

to make sure the current active navbar link is highlighted appropriately.

HBASE-28832 Migrated pagination in jqSpager.js

c3b7539

(used by the "Regions in Transition" section on master status page) so that the paginator links are styled and displayed properly.

HBASE-28832 Avoid double bottom borders with tables in tab contents

4dc02aa

Before the tab content has its own bottom border and table row also had its own bottom border. This resulted in having two lines in all table boundaries. Fix is to remove the bottom border of the table row.

HBASE-28832 Fixed Tasks table row background colors were not visible

4dbe3a2

Make sure background color is visible in tables (Tasks) where alert class is used.

HBASE-28832 Added missing favicon for Thrift UI

b568f7a

This comment has been minimized.

Sign in to view

PDavid marked this pull request as ready for review December 10, 2024 09:19

HBASE-28832 Fixed imports in table.jsp

09512e8

Reverting former change which imported: org.apache.hadoop.hbase.*

This comment has been minimized.

Sign in to view

PDavid mentioned this pull request Dec 10, 2024

HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6490

Open

This comment has been minimized.

Sign in to view

PDavid added 2 commits December 11, 2024 13:58

HBASE-28832 Fixed unstyled pager link in jqSpager.js

062f4c7

HBASE-28832 Styled Actions forms on Table Details page

1c6f572

So that buttons and textfields are displayed properly. Also removes unneeded inline styles.

PDavid marked this pull request as draft December 19, 2024 10:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6524

HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6524

PDavid commented Dec 9, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Dec 11, 2024

Apache-HBase commented Dec 11, 2024

Apache-HBase commented Dec 11, 2024

HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6524

Are you sure you want to change the base?

HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6524

Conversation

PDavid commented Dec 9, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Dec 11, 2024

Apache-HBase commented Dec 11, 2024

Apache-HBase commented Dec 11, 2024

PDavid commented Dec 9, 2024 •

edited

Loading