Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve] add connection check when get connection #2333

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

[Improve] add connection check when get connection #2333

wants to merge 15 commits into from

Conversation

yuluo-yx
Copy link
Member

No description provided.

@tomsun28
Copy link
Contributor

hi, the connection cache is the underlying code. If it throws an exception, more upper-level code logic should be considered.

yuluo-yx
yuluo-yx commented Jul 23, 2024
View reviewed changes
collector/src/main/java/org/apache/hertzbeat/collector/collect/common/cache/JdbcConnect.java Outdated
this.check();
}
catch (SQLException e) {
throw new RuntimeException(e.getMessage());
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning null here and printing the logs would probably block the @tomsun28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend collector pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuluo-yx @tomsun28 @Aias00