-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add permanently delete #1207
Conversation
Thanks for your contributions. This feat we need more time to test. For example, I tried permanently deleting users, without deleting content. It can lead to some unpredictable panic.
It turns out that some |
cf6b991
to
543ea7e
Compare
@LinkinStars I have now added delete content after deleting users. Do we still need to delete |
If an administrator deletes a user by checking the box to also delete the content, then the related questions and answers should be deleted. If the administrator does not check this option, the related content will be retained. |
543ea7e
to
37aa075
Compare
764e1c9
to
4aa27d5
Compare
We are almost done. We have tested various scenarios of what might happen. So far, only the following two locations are potentially problematic. Add default Operator
We can try to add a default operator to solve it.
Operator: &schema.QuestionPageRespOperator{ID: questionInfo.UserID}, Checking the ActivityUser
Maybe we can add a checking here, such like for _, activity := range op.Activities {
if userInfoMapping[activity.ActivityUserID] == nil {
continue
} |
@LinkinStars Thank you for testing! ❤️ |
close #1205