This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 594
Enable heap prof of stmgr in heron-shell. #2005
Open
objmagic
wants to merge
6
commits into
apache:master
Choose a base branch
from
objmagic:objmagic/stmgr-heap-profiling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
91fa952
Enable heap prof of stmgr in heron-shell.
objmagic 6649e77
Only profile when receiving signal.
objmagic f880592
Merge branch 'master' into objmagic/stmgr-heap-profiling
objmagic 8217d92
Do not change website.
objmagic e9dd0cc
Do not change website stuff.
objmagic de85730
Fix style.
objmagic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
# Copyright 2017 Twitter. All rights reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
''' stmgrheapprofhandler.py ''' | ||
import glob | ||
import json | ||
import os | ||
import signal | ||
import tornado.web | ||
|
||
from heron.shell.src.python import utils | ||
|
||
class StmgrHeapProfHandler(tornado.web.RequestHandler): | ||
""" | ||
Responsible for getting the process ID for an instance. | ||
""" | ||
|
||
# pylint: disable=attribute-defined-outside-init | ||
@tornado.web.asynchronous | ||
def get(self): | ||
''' get method ''' | ||
self.content_type = 'application/json' | ||
stmgr_pid_files = glob.glob('stmgr*.pid') | ||
try: | ||
pid_file = stmgr_pid_files[0] | ||
with open(pid_file, 'r') as f: | ||
pid = f.read() | ||
os.kill(int(pid), signal.SIGUSR1) | ||
self.write('Performing heap profiling on stream manager...') | ||
self.finish() | ||
except: | ||
self.write("Not stream manager found") | ||
self.set_status(404) | ||
self.finish() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The profiling is enabled during the whole stmgr life time.
What about adding two handlers to the stmgr server to control the profiling start & end:
In this way, the profiling is not enabled by default and there is no impact on performance.