Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

rename "topology master" to "topology manager" #3624

Merged
merged 34 commits into from
Nov 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
5d8882e
renaming "topology master" to "topology manager" in integration_test
armadillojim Oct 25, 2020
2e7b0d4
renaming "topology master" to "topology manager" in tools
armadillojim Oct 25, 2020
0e7ad0f
renaming "topology master" to "topology manager" in vagrant
armadillojim Oct 25, 2020
106bc90
renaming "topology master" to "topology manager" in deploy
armadillojim Oct 25, 2020
cbfb14c
renaming "topology master" to "topology manager" in heronpy
armadillojim Oct 25, 2020
e44291b
renaming "topology master" to "topology manager" in website2
armadillojim Oct 25, 2020
dd34e3d
renaming "topology master" to "topology manager" in scripts
armadillojim Oct 25, 2020
e929f6a
renaming "topology master" to "topology manager" in heron/scheduler-core
armadillojim Oct 25, 2020
a1c7d54
renaming "topology master" to "topology manager" in heron/tools
armadillojim Oct 26, 2020
d4cd831
renaming "topology master" to "topology manager" in heron/proto
armadillojim Oct 26, 2020
9c5c483
renaming "topology master" to "topology manager" in heron/config
armadillojim Oct 26, 2020
3d5ebc8
renaming "topology master" to "topology manager" in heron/metricscach…
armadillojim Oct 26, 2020
37a98a6
renaming "topology master" to "topology manager" in heron/common
armadillojim Oct 26, 2020
a4731dd
renaming "topology master" to "topology manager" in heron/simulator
armadillojim Oct 26, 2020
ded9f24
renaming "topology master" to "topology manager" in heron/spi
armadillojim Oct 26, 2020
95f2272
renaming "topology master" to "topology manager" in heron/statemgrs
armadillojim Oct 26, 2020
3215fe3
renaming "topology master" to "topology manager" in heron/healthmgr
armadillojim Oct 26, 2020
f494080
renaming "topology master" to "topology manager" in heron/ckptmgr
armadillojim Oct 26, 2020
d015ebb
renaming "topology master" to "topology manager" in heron/api
armadillojim Oct 26, 2020
4bc3d8d
renaming "topology master" to "topology manager" in heron/stmgr
armadillojim Oct 26, 2020
1ca01a4
renaming "topology master" to "topology manager" in heron/stmgr (miss…
armadillojim Oct 26, 2020
06285d2
renaming "topology master" to "topology manager" in heron/executor
armadillojim Oct 26, 2020
bb1b61e
renaming "topology master" to "topology manager" in heron/instance
armadillojim Oct 26, 2020
9d3206c
renaming "topology master" to "topology manager" in heron/packing
armadillojim Oct 26, 2020
afef9b5
renaming "topology master" to "topology manager" in heron/metricsmgr
armadillojim Oct 26, 2020
abda1eb
renaming "topology master" to "topology manager" in heron/schedulers
armadillojim Oct 26, 2020
42ea9ef
fixing rename of "master port" to "server port" in heron/metricsmgr
armadillojim Oct 26, 2020
ac3b4fc
renaming "topology master" to "topology manager" in heron/tmaster
armadillojim Oct 27, 2020
29d2be9
fixing linting errors from master => manager renames
armadillojim Nov 3, 2020
bf5836f
Merge branch 'master' into master-manager-conflicts
armadillojim Nov 3, 2020
4759427
fixing reversions of master => manager in website2/website/versioned_…
armadillojim Nov 3, 2020
0ede419
fixing linting errors from master => manager renames in branch merge
armadillojim Nov 3, 2020
7cf7075
merging diffs from #3585 into master => manager changes
armadillojim Nov 3, 2020
768720b
re-indenting 0ede4193bdb200de609401c610c92da0f2544277
armadillojim Nov 3, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 2 additions & 2 deletions deploy/docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ root@16092325a696:/heron# heron submit sandbox /heron/examples/heron-api-example
[2018-02-01 20:24:21 +0000] [INFO]: Successfully launched topology 'exclamation'
root@16092325a696:/heron# heron deactivate sandbox exclamation
[2018-02-01 20:24:46 +0000] [INFO]: Using cluster definition in /heron/heron-tools/conf/sandbox
[2018-02-01 20:24:47 +0000] [INFO] org.apache.heron.spi.utils.TMasterUtils: Topology command DEACTIVATE completed successfully.
[2018-02-01 20:24:47 +0000] [INFO] org.apache.heron.spi.utils.TManagerUtils: Topology command DEACTIVATE completed successfully.
[2018-02-01 20:24:47 +0000] [INFO]: Successfully deactivate topology: exclamation
root@16092325a696:/heron# heron activate sandbox exclamation
[2018-02-01 20:24:55 +0000] [INFO]: Using cluster definition in /heron/heron-tools/conf/sandbox
[2018-02-01 20:24:56 +0000] [INFO] org.apache.heron.spi.utils.TMasterUtils: Topology command ACTIVATE completed successfully.
[2018-02-01 20:24:56 +0000] [INFO] org.apache.heron.spi.utils.TManagerUtils: Topology command ACTIVATE completed successfully.
[2018-02-01 20:24:56 +0000] [INFO]: Successfully activate topology: exclamation
root@16092325a696:/heron# heron kill sandbox exclamation
[2018-02-01 20:25:08 +0000] [INFO]: Using cluster definition in /heron/heron-tools/conf/sandbox
Expand Down
2 changes: 1 addition & 1 deletion heron/api/src/java/org/apache/heron/api/bolt/IBolt.java
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
* <p>A bolt's lifecycle is as follows:</p>
* <p>
* <p>IBolt object created on client machine. The IBolt is serialized into the topology
* (using Java serialization) and submitted to the master machine of the cluster (Nimbus).
* (using Java serialization) and submitted to the primary machine of the cluster (Nimbus).
* Nimbus then launches workers which deserialize the object, call prepare on it, and then
* start processing tuples.</p>
* <p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ public static void main(String[] args) throws IOException,
Level loggingLevel = Level.INFO;
String loggingDir = systemConfig.getHeronLoggingDirectory();

// Log to file and TMaster
// Log to file and TManager
LoggingHelper.loggerInit(loggingLevel, true);
LoggingHelper.addLoggingHandler(
LoggingHelper.getFileHandler(ckptmgrId, loggingDir, true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public CheckpointManagerServer(
private void registerInitialization() {
registerOnRequest(CheckpointManager.RegisterStMgrRequest.newBuilder());

registerOnRequest(CheckpointManager.RegisterTMasterRequest.newBuilder());
registerOnRequest(CheckpointManager.RegisterTManagerRequest.newBuilder());

registerOnRequest(CheckpointManager.SaveInstanceStateRequest.newBuilder());

Expand All @@ -101,9 +101,9 @@ public void onConnect(SocketChannel channel) {
public void onRequest(REQID rid, SocketChannel channel, Message request) {
if (request instanceof CheckpointManager.RegisterStMgrRequest) {
handleStMgrRegisterRequest(rid, channel, (CheckpointManager.RegisterStMgrRequest) request);
} else if (request instanceof CheckpointManager.RegisterTMasterRequest) {
handleTMasterRegisterRequest(rid, channel,
(CheckpointManager.RegisterTMasterRequest) request);
} else if (request instanceof CheckpointManager.RegisterTManagerRequest) {
handleTManagerRegisterRequest(rid, channel,
(CheckpointManager.RegisterTManagerRequest) request);
} else if (request instanceof CheckpointManager.SaveInstanceStateRequest) {
handleSaveInstanceStateRequest(
rid, channel, (CheckpointManager.SaveInstanceStateRequest) request);
Expand Down Expand Up @@ -153,20 +153,20 @@ protected void handleCleanStatefulCheckpointRequest(
sendResponse(rid, channel, responseBuilder.build());
}

protected void handleTMasterRegisterRequest(
protected void handleTManagerRegisterRequest(
REQID rid,
SocketChannel channel,
CheckpointManager.RegisterTMasterRequest request
CheckpointManager.RegisterTManagerRequest request
) {
LOG.info("Got a TMaster register request from TMaster host:port "
LOG.info("Got a TManager register request from TManager host:port "
+ channel.socket().getRemoteSocketAddress());

CheckpointManager.RegisterTMasterResponse.Builder responseBuilder =
CheckpointManager.RegisterTMasterResponse.newBuilder();
CheckpointManager.RegisterTManagerResponse.Builder responseBuilder =
CheckpointManager.RegisterTManagerResponse.newBuilder();

if (!checkRegistrationValidity(request.getTopologyName(),
request.getTopologyId())) {
String errorMessage = String.format("The TMaster register message came with a different "
String errorMessage = String.format("The TManager register message came with a different "
+ "topologyName: %s and/or topologyId: %s",
request.getTopologyName(),
request.getTopologyId());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public class CheckpointManagerServerTest {
private static CheckpointManager.GetInstanceStateRequest getInstanceStateRequest;
private static CheckpointManager.CleanStatefulCheckpointRequest cleanStatefulCheckpointRequest;
private static CheckpointManager.RegisterStMgrRequest registerStmgrRequest;
private static CheckpointManager.RegisterTMasterRequest registerTMasterRequest;
private static CheckpointManager.RegisterTManagerRequest registerTManagerRequest;

private static PhysicalPlans.Instance instance;

Expand Down Expand Up @@ -137,7 +137,7 @@ public static void setup() throws Exception {
.setPhysicalPlan(pplan)
.build();

registerTMasterRequest = CheckpointManager.RegisterTMasterRequest.newBuilder()
registerTManagerRequest = CheckpointManager.RegisterTManagerRequest.newBuilder()
.setTopologyId(TOPOLOGY_ID)
.setTopologyName(TOPOLOGY_NAME)
.build();
Expand Down Expand Up @@ -224,10 +224,10 @@ public void handleResponse(HeronClient client, StatusCode status,
}

@Test
public void testRegisterTMaster() throws Exception {
runTest(TestRequestHandler.RequestType.REGISTER_TMASTER,
public void testRegisterTManager() throws Exception {
runTest(TestRequestHandler.RequestType.REGISTER_TMANAGER,
new HeronServerTester.SuccessResponseHandler(
CheckpointManager.RegisterTMasterResponse.class));
CheckpointManager.RegisterTManagerResponse.class));
}

@Test
Expand All @@ -249,8 +249,8 @@ public enum RequestType {
CheckpointManager.CleanStatefulCheckpointResponse.getDescriptor()),
REGISTER_STMGR(registerStmgrRequest,
CheckpointManager.RegisterStMgrResponse.getDescriptor()),
REGISTER_TMASTER(registerTMasterRequest,
CheckpointManager.RegisterTMasterResponse.getDescriptor());
REGISTER_TMANAGER(registerTManagerRequest,
CheckpointManager.RegisterTManagerResponse.getDescriptor());

private Message requestMessage;
private Descriptors.Descriptor responseMessageDescriptor;
Expand Down
60 changes: 30 additions & 30 deletions heron/common/src/cpp/config/heron-internals-config-reader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ sp_int32 HeronInternalsConfigReader::GetHeronLoggingMaximumFiles() {
return config_[HeronInternalsConfigVars::HERON_LOGGING_MAXIMUM_FILES].as<int>();
}

sp_int32 HeronInternalsConfigReader::GetCheckTMasterLocationIntervalSec() {
return config_[HeronInternalsConfigVars::HERON_CHECK_TMASTER_LOCATION_INTERVAL_SEC].as<int>();
sp_int32 HeronInternalsConfigReader::GetCheckTManagerLocationIntervalSec() {
return config_[HeronInternalsConfigVars::HERON_CHECK_TMANAGER_LOCATION_INTERVAL_SEC].as<int>();
}

sp_int32 HeronInternalsConfigReader::GetHeronLoggingPruneIntervalSec() {
Expand Down Expand Up @@ -158,8 +158,8 @@ sp_int32 HeronInternalsConfigReader::GetHeronMetricsmgrScribePeriodicFlushInterv
.as<int>();
}

sp_int32 HeronInternalsConfigReader::GetHeronMetricsmgrReconnectTmasterIntervalSec() {
return config_[HeronInternalsConfigVars::HERON_METRICSMGR_RECONNECT_TMASTER_INTERVAL_SEC]
sp_int32 HeronInternalsConfigReader::GetHeronMetricsmgrReconnectTmanagerIntervalSec() {
return config_[HeronInternalsConfigVars::HERON_METRICSMGR_RECONNECT_TMANAGER_INTERVAL_SEC]
.as<int>();
}

Expand All @@ -168,52 +168,52 @@ sp_int32 HeronInternalsConfigReader::GetHeronMetricsmgrNetworkOptionsMaximumPack
.as<int>();
}

sp_int32 HeronInternalsConfigReader::GetHeronTmasterMetricsCollectorMaximumIntervalMin() {
return config_[HeronInternalsConfigVars::HERON_TMASTER_METRICS_COLLECTOR_MAXIMUM_INTERVAL_MIN]
sp_int32 HeronInternalsConfigReader::GetHeronTmanagerMetricsCollectorMaximumIntervalMin() {
return config_[HeronInternalsConfigVars::HERON_TMANAGER_METRICS_COLLECTOR_MAXIMUM_INTERVAL_MIN]
.as<int>();
}

sp_int32 HeronInternalsConfigReader::GetHeronTmasterEstablishRetryTimes() {
return config_[HeronInternalsConfigVars::HERON_TMASTER_ESTABLISH_RETRY_TIMES].as<int>();
sp_int32 HeronInternalsConfigReader::GetHeronTmanagerEstablishRetryTimes() {
return config_[HeronInternalsConfigVars::HERON_TMANAGER_ESTABLISH_RETRY_TIMES].as<int>();
}

sp_int32 HeronInternalsConfigReader::GetHeronTmasterEstablishRetryIntervalSec() {
return config_[HeronInternalsConfigVars::HERON_TMASTER_ESTABLISH_RETRY_INTERVAL_SEC].as<int>();
sp_int32 HeronInternalsConfigReader::GetHeronTmanagerEstablishRetryIntervalSec() {
return config_[HeronInternalsConfigVars::HERON_TMANAGER_ESTABLISH_RETRY_INTERVAL_SEC].as<int>();
}

sp_int32 HeronInternalsConfigReader::GetHeronTmasterNetworkMasterOptionsMaximumPacketMb() {
return config_[HeronInternalsConfigVars::HERON_TMASTER_NETWORK_MASTER_OPTIONS_MAXIMUM_PACKET_MB]
sp_int32 HeronInternalsConfigReader::GetHeronTmanagerNetworkServerOptionsMaximumPacketMb() {
return config_[HeronInternalsConfigVars::HERON_TMANAGER_NETWORK_SERVER_OPTIONS_MAXIMUM_PACKET_MB]
.as<int>();
}

sp_int32 HeronInternalsConfigReader::GetHeronTmasterNetworkControllerOptionsMaximumPacketMb() {
sp_int32 HeronInternalsConfigReader::GetHeronTmanagerNetworkControllerOptionsMaximumPacketMb() {
return config_
[HeronInternalsConfigVars::HERON_TMASTER_NETWORK_CONTROLLER_OPTIONS_MAXIMUM_PACKET_MB]
[HeronInternalsConfigVars::HERON_TMANAGER_NETWORK_CONTROLLER_OPTIONS_MAXIMUM_PACKET_MB]
.as<int>();
}

sp_int32 HeronInternalsConfigReader::GetHeronTmasterNetworkStatsOptionsMaximumPacketMb() {
return config_[HeronInternalsConfigVars::HERON_TMASTER_NETWORK_STATS_OPTIONS_MAXIMUM_PACKET_MB]
sp_int32 HeronInternalsConfigReader::GetHeronTmanagerNetworkStatsOptionsMaximumPacketMb() {
return config_[HeronInternalsConfigVars::HERON_TMANAGER_NETWORK_STATS_OPTIONS_MAXIMUM_PACKET_MB]
.as<int>();
}

sp_int32 HeronInternalsConfigReader::GetHeronTmasterMetricsCollectorPurgeIntervalSec() {
return config_[HeronInternalsConfigVars::HERON_TMASTER_METRICS_COLLECTOR_PURGE_INTERVAL_SEC]
sp_int32 HeronInternalsConfigReader::GetHeronTmanagerMetricsCollectorPurgeIntervalSec() {
return config_[HeronInternalsConfigVars::HERON_TMANAGER_METRICS_COLLECTOR_PURGE_INTERVAL_SEC]
.as<int>();
}

sp_int32 HeronInternalsConfigReader::GetHeronTmasterMetricsCollectorMaximumException() {
return config_[HeronInternalsConfigVars::HERON_TMASTER_METRICS_COLLECTOR_MAXIMUM_EXCEPTION]
sp_int32 HeronInternalsConfigReader::GetHeronTmanagerMetricsCollectorMaximumException() {
return config_[HeronInternalsConfigVars::HERON_TMANAGER_METRICS_COLLECTOR_MAXIMUM_EXCEPTION]
.as<int>();
}

bool HeronInternalsConfigReader::GetHeronTmasterMetricsNetworkBindAllInterfaces() {
return config_[HeronInternalsConfigVars::HERON_TMASTER_METRICS_NETWORK_BINDALLINTERFACES]
bool HeronInternalsConfigReader::GetHeronTmanagerMetricsNetworkBindAllInterfaces() {
return config_[HeronInternalsConfigVars::HERON_TMANAGER_METRICS_NETWORK_BINDALLINTERFACES]
.as<bool>();
}

sp_int32 HeronInternalsConfigReader::GetHeronTmasterStmgrStateTimeoutSec() {
return config_[HeronInternalsConfigVars::HERON_TMASTER_STMGR_STATE_TIMEOUT_SEC].as<int>();
sp_int32 HeronInternalsConfigReader::GetHeronTmanagerStmgrStateTimeoutSec() {
return config_[HeronInternalsConfigVars::HERON_TMANAGER_STMGR_STATE_TIMEOUT_SEC].as<int>();
}

sp_int32 HeronInternalsConfigReader::GetHeronStreammgrCacheDrainFrequencyMs() {
Expand All @@ -237,17 +237,17 @@ sp_int32 HeronInternalsConfigReader::GetHeronStreammgrXormgrRotatingmapNbuckets(
return config_[HeronInternalsConfigVars::HERON_STREAMMGR_XORMGR_ROTATINGMAP_NBUCKETS].as<int>();
}

sp_int32 HeronInternalsConfigReader::GetHeronStreammgrClientReconnectTmasterMaxAttempts() {
return config_[HeronInternalsConfigVars::HERON_STREAMMGR_CLIENT_RECONNECT_TMASTER_MAX_ATTEMPTS]
sp_int32 HeronInternalsConfigReader::GetHeronStreammgrClientReconnectTmanagerMaxAttempts() {
return config_[HeronInternalsConfigVars::HERON_STREAMMGR_CLIENT_RECONNECT_TMANAGER_MAX_ATTEMPTS]
.as<int>();
}

sp_int32 HeronInternalsConfigReader::GetHeronStreammgrClientReconnectIntervalSec() {
return config_[HeronInternalsConfigVars::HERON_STREAMMGR_CLIENT_RECONNECT_INTERVAL_SEC].as<int>();
}

sp_int32 HeronInternalsConfigReader::GetHeronStreammgrClientReconnectTmasterIntervalSec() {
return config_[HeronInternalsConfigVars::HERON_STREAMMGR_CLIENT_RECONNECT_TMASTER_INTERVAL_SEC]
sp_int32 HeronInternalsConfigReader::GetHeronStreammgrClientReconnectTmanagerIntervalSec() {
return config_[HeronInternalsConfigVars::HERON_STREAMMGR_CLIENT_RECONNECT_TMANAGER_INTERVAL_SEC]
.as<int>();
}

Expand All @@ -256,8 +256,8 @@ sp_int32 HeronInternalsConfigReader::GetHeronStreammgrNetworkOptionsMaximumPacke
.as<int>();
}

sp_int32 HeronInternalsConfigReader::GetHeronStreammgrTmasterHeartbeatIntervalSec() {
return config_[HeronInternalsConfigVars::HERON_STREAMMGR_TMASTER_HEARTBEAT_INTERVAL_SEC]
sp_int32 HeronInternalsConfigReader::GetHeronStreammgrTmanagerHeartbeatIntervalSec() {
return config_[HeronInternalsConfigVars::HERON_STREAMMGR_TMANAGER_HEARTBEAT_INTERVAL_SEC]
.as<int>();
}

Expand Down
52 changes: 26 additions & 26 deletions heron/common/src/cpp/config/heron-internals-config-reader.h
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ class HeronInternalsConfigReader : public YamlFileReader {
// The maximum number of log files
sp_int32 GetHeronLoggingMaximumFiles();

// The interval after which we check if the tmaster location
// The interval after which we check if the tmanager location
// has been set or not
sp_int32 GetCheckTMasterLocationIntervalSec();
sp_int32 GetCheckTManagerLocationIntervalSec();

// The interval in seconds to prune logging files in C+++
sp_int32 GetHeronLoggingPruneIntervalSec();
Expand Down Expand Up @@ -105,44 +105,44 @@ class HeronInternalsConfigReader : public YamlFileReader {
// The interval in seconds to flush cached metircs to scribe
sp_int32 GetHeronMetricsmgrScribePeriodicFlushIntervalSec();

// The interval in seconds to reconnect to tmaster if a connection failure happens
sp_int32 GetHeronMetricsmgrReconnectTmasterIntervalSec();
// The interval in seconds to reconnect to tmanager if a connection failure happens
sp_int32 GetHeronMetricsmgrReconnectTmanagerIntervalSec();

// The maximum packet size in MB of metrics manager's network options
sp_int32 GetHeronMetricsmgrNetworkOptionsMaximumPacketMb();

/**
* Tmaster Config Getters
* Tmanager Config Getters
**/
// The maximum interval in minutes of metrics to be kept in tmaster
sp_int32 GetHeronTmasterMetricsCollectorMaximumIntervalMin();
// The maximum interval in minutes of metrics to be kept in tmanager
sp_int32 GetHeronTmanagerMetricsCollectorMaximumIntervalMin();

// The maximum time to retry to establish the tmaster
sp_int32 GetHeronTmasterEstablishRetryTimes();
// The maximum time to retry to establish the tmanager
sp_int32 GetHeronTmanagerEstablishRetryTimes();

// The interval to retry to establish the tmaster
sp_int32 GetHeronTmasterEstablishRetryIntervalSec();
// The interval to retry to establish the tmanager
sp_int32 GetHeronTmanagerEstablishRetryIntervalSec();

// The maximum packet size in MB of tmaster's network options for stmgrs to connect to
sp_int32 GetHeronTmasterNetworkMasterOptionsMaximumPacketMb();
// The maximum packet size in MB of tmanager's network options for stmgrs to connect to
sp_int32 GetHeronTmanagerNetworkServerOptionsMaximumPacketMb();

// The maximum packet size in MB of tmaster's network options for scheduler to connect to
sp_int32 GetHeronTmasterNetworkControllerOptionsMaximumPacketMb();
// The maximum packet size in MB of tmanager's network options for scheduler to connect to
sp_int32 GetHeronTmanagerNetworkControllerOptionsMaximumPacketMb();

// The maximum packet size in MB of tmaster's network options for stat queries
sp_int32 GetHeronTmasterNetworkStatsOptionsMaximumPacketMb();
// The maximum packet size in MB of tmanager's network options for stat queries
sp_int32 GetHeronTmanagerNetworkStatsOptionsMaximumPacketMb();

// The inteval for tmaster to purge metrics from socket
sp_int32 GetHeronTmasterMetricsCollectorPurgeIntervalSec();
// The inteval for tmanager to purge metrics from socket
sp_int32 GetHeronTmanagerMetricsCollectorPurgeIntervalSec();

// The maximum # of exception to be stored in tmetrics collector, to prevent potential OOM
sp_int32 GetHeronTmasterMetricsCollectorMaximumException();
sp_int32 GetHeronTmanagerMetricsCollectorMaximumException();

// Should metrics server bind on all interfaces
bool GetHeronTmasterMetricsNetworkBindAllInterfaces();
bool GetHeronTmanagerMetricsNetworkBindAllInterfaces();

// The timeout in seconds for stream mgr, compared with (current time - last heartbeat time)
sp_int32 GetHeronTmasterStmgrStateTimeoutSec();
sp_int32 GetHeronTmanagerStmgrStateTimeoutSec();

/**
* Stream manager Config Getters
Expand All @@ -167,16 +167,16 @@ class HeronInternalsConfigReader : public YamlFileReader {
sp_int32 GetHeronStreammgrClientReconnectIntervalSec();

// The reconnect interval to tamster in second for stream manager client
sp_int32 GetHeronStreammgrClientReconnectTmasterIntervalSec();
sp_int32 GetHeronStreammgrClientReconnectTmanagerIntervalSec();

// The max reconnect attempts to tmaster for stream manager client
sp_int32 GetHeronStreammgrClientReconnectTmasterMaxAttempts();
// The max reconnect attempts to tmanager for stream manager client
sp_int32 GetHeronStreammgrClientReconnectTmanagerMaxAttempts();

// The maximum packet size in MB of stream manager's network options
sp_int32 GetHeronStreammgrNetworkOptionsMaximumPacketMb();

// The interval in seconds to send heartbeat
sp_int32 GetHeronStreammgrTmasterHeartbeatIntervalSec();
sp_int32 GetHeronStreammgrTmanagerHeartbeatIntervalSec();

// Maximum batch size in MB to read by stream manager from socket
sp_int32 GetHeronStreammgrConnectionReadBatchSizeMb();
Expand Down
Loading