Skip to content

Commit

Permalink
refactor(FDS): Terminate the FDS supporting (#1695)
Browse files Browse the repository at this point in the history
#1644

As it known, the [FDS](https://docs.api.xiaomi.com/fds/introduction.html)
is a Xiaomi internal storage system, the community users are not possible
to use FDS as a [Backup](https://pegasus.apache.org/zh/administration/cold-backup)
target, and since Pegasus [2.2.0](https://github.com/apache/incubator-pegasus/releases/tag/v2.2.0)
(released in Jun, 2021), the Backup start to support using Apache HDFS as
the target storage.

This patch terminates the supporting of FDS in the next version. Of course,
we will still fix critical bugs if there are in released versions.

TODO: backup/restore modules have to update.
  • Loading branch information
acelyc111 authored Nov 29, 2023
1 parent 2ff8c02 commit 41ff58d
Show file tree
Hide file tree
Showing 29 changed files with 2 additions and 1,889 deletions.
1 change: 0 additions & 1 deletion .licenserc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ header:
- 'src/replica/duplication/test/log.1.0.handle_real_private_log2'
- 'src/replica/duplication/test/log.1.0.all_loaded_are_write_empties'
# Used for patches for thirdparties.
- 'thirdparty/fix_fds_for_macos.patch'
- 'thirdparty/fix_jemalloc_for_m1_on_macos.patch'
- 'thirdparty/fix_libevent_for_macos.patch'
- 'thirdparty/fix_prometheus-cpp_limits.patch'
Expand Down
3 changes: 0 additions & 3 deletions cmake_modules/BaseFunctions.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -222,9 +222,6 @@ function(dsn_setup_compiler_flags)
# use frame pointers to allow simple stack frame walking for backtraces.
# This has a small perf hit but worth it for the ability to profile in production
add_compile_options( -fno-omit-frame-pointer)
# -Wno-implicit-float-conversion
# Poco/Dynamic/VarHolder.h uses 'unsigned long' to 'float' conversion
add_compile_options(-Wno-implicit-float-conversion)

find_program(CCACHE_FOUND ccache)
if(CCACHE_FOUND)
Expand Down
1 change: 0 additions & 1 deletion scripts/pack_server.sh
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ copy_file ${BUILD_LATEST_DIR}/output/bin/pegasus_server/pegasus_server ${pack}/b
copy_file ${BUILD_LATEST_DIR}/output/lib/libdsn_meta_server.so ${pack}/bin
copy_file ${BUILD_LATEST_DIR}/output/lib/libdsn_replica_server.so ${pack}/bin
copy_file ${BUILD_LATEST_DIR}/output/lib/libdsn_utils.so ${pack}/bin
copy_file ./thirdparty/output/lib/libPoco*.so.* ${pack}/bin

if [ "$use_jemalloc" == "on" ]; then
copy_file ./thirdparty/output/lib/libjemalloc.so.2 ${pack}/bin
Expand Down
1 change: 0 additions & 1 deletion scripts/pack_tools.sh
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ cp -v -r ${BUILD_LATEST_DIR}/output/bin/pegasus_pressureclient ${pack}/bin/

mkdir -p ${pack}/lib
copy_file ${BUILD_LATEST_DIR}/output/lib/*.so* ${pack}/lib/
copy_file ./thirdparty/output/lib/libPoco*.so.* ${pack}/lib/

if [ "$use_jemalloc" == "on" ]; then
copy_file ./thirdparty/output/lib/libjemalloc.so.2 ${pack}/lib/
Expand Down
1 change: 0 additions & 1 deletion src/block_service/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ set(MY_BOOST_LIBS Boost::system Boost::filesystem)

dsn_add_static_library()

add_subdirectory(fds)
add_subdirectory(hdfs)
add_subdirectory(local)
add_subdirectory(test)
5 changes: 0 additions & 5 deletions src/block_service/block_service_manager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include <vector>

#include "block_service/block_service.h"
#include "block_service/fds/fds_service.h"
#include "block_service/hdfs/hdfs_service.h"
#include "block_service/local/local_service.h"
#include "runtime/task/task_code.h"
Expand All @@ -39,10 +38,6 @@ namespace block_service {

block_service_registry::block_service_registry()
{
CHECK(utils::factory_store<block_filesystem>::register_factory(
"fds_service", block_filesystem::create<fds_service>, PROVIDER_TYPE_MAIN),
"register fds_service failed");

CHECK(utils::factory_store<block_filesystem>::register_factory(
"hdfs_service", block_filesystem::create<hdfs_service>, PROVIDER_TYPE_MAIN),
"register hdfs_service failed");
Expand Down
35 changes: 0 additions & 35 deletions src/block_service/fds/CMakeLists.txt

This file was deleted.

Loading

0 comments on commit 41ff58d

Please sign in to comment.