Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: support close admin-cli client #2160

Open
ruojieranyishen opened this issue Dec 2, 2024 · 0 comments
Open

refactor: support close admin-cli client #2160

ruojieranyishen opened this issue Dec 2, 2024 · 0 comments
Labels
type/enhancement Indicates new feature requests

Comments

@ruojieranyishen
Copy link
Collaborator

Feature Request

Is your feature request related to a problem? Please describe:
I found that the current admin CLI client does not provide an interface to close replica server TCP connections. And the QueryAllNodesDiskInfo function is difficult to use. sendQueryDiskInfoRequest function is private.

Describe the feature you'd like:

  1. Support close admin-cli client.
  2. Refactor QueryAllNodesDiskInfo function.
@ruojieranyishen ruojieranyishen added the type/enhancement Indicates new feature requests label Dec 2, 2024
ruojieranyishen pushed a commit to ruojieranyishen/incubator-pegasus that referenced this issue Dec 2, 2024
apache#2160

Current admin-cli client does not provide an interface to
close replica server TCP connections.
And the QueryAllNodesDiskInfo function is difficult to use.
SendQueryDiskInfoRequest function is private.
ruojieranyishen pushed a commit to ruojieranyishen/incubator-pegasus that referenced this issue Dec 3, 2024
apache#2160

Current admin-cli client does not provide an interface to
close replica server TCP connections.
And the QueryAllNodesDiskInfo function is difficult to use.
SendQueryDiskInfoRequest function is private.
ruojieranyishen pushed a commit to ruojieranyishen/incubator-pegasus that referenced this issue Dec 3, 2024
apache#2160

Current admin-cli client does not provide an interface to
close replica server TCP connections.
And the QueryAllNodesDiskInfo function is difficult to use.
SendQueryDiskInfoRequest function is private.
@ruojieranyishen ruojieranyishen changed the title Refactor(admin-cli): support close client refactor: support close admin-cli client Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Indicates new feature requests
Projects
None yet
Development

No branches or pull requests

1 participant