refactor: support close admin-cli client #2162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apache#2160 Current admin-cli client does not provide an interface to close replica server TCP connections. And the QueryAllNodesDiskInfo function is difficult to use. SendQueryDiskInfoRequest function is private.
ruojieranyishen
force-pushed
the
optAdmincli
branch
from
bf21065 to
b62189a
Compare
ruojieranyishen
changed the title
acelyc111
reviewed
Dec 4, 2024
acelyc111
previously approved these changes
Dec 10, 2024
empiredan
reviewed
Dec 13, 2024
acelyc111
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2160
Current admin-cli client does not provide an interface to close replica server TCP connections.
And
QueryAllNodesDiskInfofunction is difficult to use.SendQueryDiskInfoRequestfunction is private.What problem does this PR solve?
support close client, disconnect tcp link with replica server.
Tests
The TCP connection to the replica server cannot be closed.
After support close client，the persistent TCP connection between admincli and the replica server can be disconnected.
