feat(FQDN): Support to communicate with servers and clients by host_port #1658

GehaFearless · 2023-10-26T03:25:14Z

Add a new host_port type field if rpc_address field exists in IDL structures.
Use both rpc_address and the optional host_port fields in C++ code.
Use host_port to communicate with remote nodes firstly.

TODO:

Make sure everything works well after upgrading from old versions without any config changes
Make sure old version client is able to access the new version cluster
Make sure new version client is able to access the old version cluster

NOTE:
It's not able to upgrade Pegasus cluster and clients smoothly to the new version with FQDN enabled, it's needed to follow the steps if you want to enable the FQDN feature:

Stop the cluster and clients
Set the new configs (using hostnames instead of IPs)
Rebuild the metadata of the cluster (See https://pegasus.apache.org/zh/administration/meta-recovery)
Start the whole cluster and application clients

NOTE: Do not support rolling restart servers in the cluster with FQDN related configs changed

src/client/partition_resolver.cpp

src/runtime/rpc/rpc_host_port.h

src/client/replication_ddl_client.cpp

run.sh

src/client/partition_resolver.cpp

src/client/partition_resolver_simple.cpp

src/client/replication_ddl_client.cpp

src/common/replication_common.cpp

src/failure_detector/failure_detector.cpp

src/meta/cluster_balance_policy.cpp

src/meta/greedy_load_balancer.cpp

acelyc111 · 2023-12-12T09:57:42Z

Some changes can be separated to another patch, for example, the changes in:

src/common/json_helper.h and its tests.
src/runtime/rpc/rpc_host_port.h (add some tests as well)

run.sh

src/client/partition_resolver.cpp

src/client/partition_resolver_simple.cpp

src/meta/meta_bulk_load_service.cpp

src/meta/meta_data.cpp

src/test/function_test/recovery/test_recovery.cpp

src/test/function_test/base_api/test_batch_get.cpp

src/shell/commands/detect_hotkey.cpp

src/client/replication_ddl_client.cpp

src/meta/app_balance_policy.cpp

src/runtime/rpc/dns_resolver.cpp

…port on thrift struct

src/meta/duplication/meta_duplication_service.cpp

src/meta/test/meta_bulk_load_service_test.cpp

src/meta/test/meta_duplication_service_test.cpp

src/meta/test/meta_test_base.cpp

src/meta/test/misc/misc.h

src/shell/commands/rebalance.cpp

src/shell/commands/table_management.cpp

acelyc111 · 2024-03-12T12:36:40Z

src/test/function_test/config.ini

@@ -75,8 +75,8 @@ rpc_timeout_milliseconds = 5000
 lb_interval_ms = 3000

 [pegasus.clusters]
-onebox = 127.0.0.1:34601,127.0.0.1:34602,127.0.0.1:34603
-single_master_cluster = 127.0.0.1:34601
+onebox = @LOCAL_HOSTNAME@:34601,@LOCAL_HOSTNAME@:34602,@LOCAL_HOSTNAME@:34603


TODO: check ip is acceptable as well

acelyc111 · 2024-03-12T12:38:33Z

src/test/function_test/recovery/test_recovery.cpp

        result.reserve(ports.size());
        for (const auto &port : ports) {
-            result.emplace_back(dsn::rpc_address(global_env::instance()._host_ip, port));
+            char hostname[1024];
+            gethostname(hostname, 1024);


TODO: change _host_ip and use it

acelyc111 · 2024-03-12T12:39:25Z

src/test/function_test/utils/test_util.cpp

@@ -89,6 +89,7 @@ void test_util::SetUp()
    ddl_client_ = std::make_shared<replication_ddl_client>(meta_list_);
    ASSERT_TRUE(ddl_client_ != nullptr);
    ddl_client_->set_max_wait_app_ready_secs(120);
+    ddl_client_->set_meta_servers_leader();


TODO: is it necessary?

github-actions bot added scripts cpp build thrift labels Oct 26, 2023

GehaFearless changed the title ~~Liguohao fqdn2~~ feat(FQDN): Replace rpc_address to host_prot for function & Add host_port on thrift struct Oct 26, 2023

GehaFearless force-pushed the liguohao_fqdn2 branch 4 times, most recently from faec076 to 2e6e527 Compare November 8, 2023 09:24

GehaFearless commented Nov 8, 2023

View reviewed changes

src/client/partition_resolver.cpp Outdated Show resolved Hide resolved

GehaFearless commented Nov 8, 2023

View reviewed changes

src/runtime/rpc/rpc_host_port.h Outdated Show resolved Hide resolved

GehaFearless commented Nov 16, 2023

View reviewed changes

src/client/replication_ddl_client.cpp Show resolved Hide resolved

acelyc111 reviewed Nov 22, 2023

View reviewed changes

GehaFearless force-pushed the liguohao_fqdn2 branch 2 times, most recently from 25c9fdd to a1fd9e0 Compare November 28, 2023 06:59

GehaFearless force-pushed the liguohao_fqdn2 branch 5 times, most recently from 5acccd7 to 47adb77 Compare December 8, 2023 09:56

acelyc111 reviewed Dec 12, 2023

View reviewed changes

GehaFearless force-pushed the liguohao_fqdn2 branch 5 times, most recently from 6ff7b18 to b3368ad Compare December 25, 2023 12:34

GehaFearless force-pushed the liguohao_fqdn2 branch 2 times, most recently from 612b1aa to 9a0e467 Compare December 28, 2023 07:55

acelyc111 reviewed Jan 2, 2024

View reviewed changes

acelyc111 force-pushed the liguohao_fqdn2 branch 2 times, most recently from cdde494 to 718a6a0 Compare February 4, 2024 08:31

acelyc111 reviewed Feb 5, 2024

View reviewed changes

src/runtime/rpc/dns_resolver.cpp Outdated Show resolved Hide resolved

GehaFearless force-pushed the liguohao_fqdn2 branch 3 times, most recently from 936a7ab to cb5f3b9 Compare February 7, 2024 07:02

GehaFearless force-pushed the liguohao_fqdn2 branch 6 times, most recently from 6fc12e5 to e2a6fa2 Compare February 20, 2024 02:41

GehaFearless force-pushed the liguohao_fqdn2 branch 5 times, most recently from 61335d2 to 5e7af7b Compare March 4, 2024 06:11

GehaFearless force-pushed the liguohao_fqdn2 branch 3 times, most recently from 9df655a to 818b1d0 Compare March 8, 2024 09:04

GehaFearless changed the title ~~feat(FQDN): Replace rpc_address to host_prot for function & Add host_port on thrift struct~~ feat(FQDN): Replace rpc_address to host_port for function & Add host_port on thrift struct Mar 11, 2024

feat(FQDN): Replace rpc_address to host_prot for function & Add host_…

bfd1161

…port on thrift struct

GehaFearless force-pushed the liguohao_fqdn2 branch from 818b1d0 to bfd1161 Compare March 11, 2024 10:04

GehaFearless closed this Mar 11, 2024

GehaFearless force-pushed the liguohao_fqdn2 branch from bfd1161 to 2bcdaf5 Compare March 11, 2024 13:52

GehaFearless reopened this Mar 12, 2024

acelyc111 approved these changes Mar 12, 2024

View reviewed changes

acelyc111 changed the title ~~feat(FQDN): Replace rpc_address to host_port for function & Add host_port on thrift struct~~ feat(FQDN): Support to communicate with servers and clients by host_port Mar 13, 2024

empiredan approved these changes Mar 13, 2024

View reviewed changes

empiredan merged commit 802d2c2 into apache:master Mar 13, 2024
167 of 177 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(FQDN): Support to communicate with servers and clients by host_port #1658

feat(FQDN): Support to communicate with servers and clients by host_port #1658

GehaFearless commented Oct 26, 2023 •

edited by acelyc111

Loading

acelyc111 commented Dec 12, 2023

acelyc111 Mar 12, 2024

acelyc111 Mar 12, 2024

acelyc111 Mar 12, 2024

feat(FQDN): Support to communicate with servers and clients by host_port #1658

feat(FQDN): Support to communicate with servers and clients by host_port #1658

Conversation

GehaFearless commented Oct 26, 2023 • edited by acelyc111 Loading

acelyc111 commented Dec 12, 2023

acelyc111 Mar 12, 2024

Choose a reason for hiding this comment

acelyc111 Mar 12, 2024

Choose a reason for hiding this comment

acelyc111 Mar 12, 2024

Choose a reason for hiding this comment

GehaFearless commented Oct 26, 2023 •

edited by acelyc111

Loading