-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix insert/load with timestamp of Long.MIN_VALUE and LONG.MAX_VALUE #14491
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java
@@ -336,7 +344,7 @@ public void insertByObjAndNotInferTypeTest() { | |||
expected.add(TSDataType.TEXT.name()); | |||
|
|||
Set<String> actual = new HashSet<>(); | |||
SessionDataSet dataSet = session.executeQueryStatement("show timeseries root.**"); | |||
SessionDataSet dataSet = session.executeQueryStatement("show timeseries root.sg1.**"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This avoids conflicts with other tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previousTime also needs to be modified. This value is used in checkPreviousTimeAndUpdate to check the order of timestamps. Perhaps we can add a boolean to determine whether to set initial values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
These classes also need to be modified:
|
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
No description provided.