[region migration] Make peer list correct when IoTConsensus & IoTConsensusV2 & Ratis starting #14505
+375
−233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensus.java
Show resolved
Hide resolved
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/IConsensus.java
Outdated
Show resolved
Hide resolved
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensus.java
Show resolved
Hide resolved
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensus.java
Outdated
Show resolved
Hide resolved
...tanode/src/main/java/org/apache/iotdb/db/pipe/consensus/ConsensusPipeDataNodeDispatcher.java
Show resolved
Hide resolved
...tanode/src/main/java/org/apache/iotdb/db/pipe/consensus/ConsensusPipeDataNodeDispatcher.java
Show resolved
Hide resolved
| consensusPipeManager, | ||
| syncClientManager); | ||
| stateMachineMap.put(consensusGroupId, consensus); | ||
| consensus.start(true); |
There was a problem hiding this comment.
can we start them after resetpeerlist?
There was a problem hiding this comment.
Not sure. @Pengzna cc
There was a problem hiding this comment.
we must start them in compelableFuture to avoid start failure. may put resetPeerListWithoutThrow.accept into the completableFuture.
There was a problem hiding this comment.
maybe we can put all logic in compelableFuture but start them in the last?
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/pipe/PipeConsensus.java
Outdated
Show resolved
Hide resolved
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/simple/SimpleConsensus.java
Outdated
Show resolved
Hide resolved
Pengzna
reviewed
Dec 20, 2024
...mmons/src/main/java/org/apache/iotdb/commons/pipe/config/constant/PipeConnectorConstant.java
Outdated
Show resolved
Hide resolved
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensus.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.