Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use schema last cache to speed up the last and last_by aggregations in table model #14526

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Beyyes
Copy link
Member

@Beyyes Beyyes commented Dec 23, 2024

Description

Content1 ...

Content2 ...

Content3 ...


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0.30211% with 330 lines in your changes missing coverage. Please review.

Project coverage is 39.34%. Comparing base (81db737) to head (14fdf11).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...ator/source/relational/TableLastQueryOperator.java 0.00% 274 Missing ⚠️
...eryengine/plan/planner/TableOperatorGenerator.java 0.00% 22 Missing ⚠️
.../relational/TableAggregationTableScanOperator.java 0.00% 17 Missing ⚠️
...urce/relational/aggregation/LastByAccumulator.java 0.00% 5 Missing ⚠️
...source/relational/aggregation/LastAccumulator.java 0.00% 3 Missing ⚠️
...source/relational/aggregation/TableAggregator.java 0.00% 3 Missing ⚠️
...plan/planner/plan/parameter/SeriesScanOptions.java 0.00% 3 Missing ⚠️
.../relational/aggregation/LastByDescAccumulator.java 0.00% 1 Missing ⚠️
...ce/relational/aggregation/LastDescAccumulator.java 0.00% 1 Missing ⚠️
...ueryengine/plan/planner/OperatorTreeGenerator.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14526      +/-   ##
============================================
- Coverage     39.43%   39.34%   -0.10%     
  Complexity      185      185              
============================================
  Files          4335     4342       +7     
  Lines        275035   275646     +611     
  Branches      33549    33680     +131     
============================================
- Hits         108465   108454      -11     
- Misses       166570   167192     +622     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant