KAFKA-18290: Remove deprecated methods of FeatureUpdate #18246
+23
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LoganZhuZzz could you please fix the conflicts? |
@chia7712 Sorry, I didn’t see it earlier, but it’s already been handled. |
|
the failed test is traced by https://issues.apache.org/jira/browse/KAFKA-15474 |
|
@LoganZhuZzz Could you please update the admin docs too? https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/admin/Admin.java#L1448 |
Thank you for pointing that out! I’ve updated the admin docs to reflect the changes. |
|
@LoganZhuZzz please fix the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated methods
Committer Checklist (excluded from commit message)