Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tighten up initialization of DisjunctionDISIApproximation #14082

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tighten up initialization of DisjunctionDISIApproximation #14082

wants to merge 1 commit into from

Conversation

gsmiller
Copy link
Contributor

  1. Add all leads to heap at once via heapfiy operation
  2. Very minor tweaks to cost computation loops (avoid multiple iterations)

Checked benchmarks and nothing showed up (as expected). I still think it's nice to leverage heapify here since it's available.

@gsmiller
Tighten up initialization of DisjunctionDISIApproximation
0a9b49a 
1. Add all leads to heap at once via heapfiy operation
2. Very minor tweaks to cost computation loops (avoid multiple iterations)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpountz jpountz jpountz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsmiller @jpountz