[MNGSITE-540] Use correct plugin for reporting #216
Conversation
maven-scm-plugin/pom.xml
Outdated
| @@ -228,7 +228,7 @@ | |||
| <plugins> | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-plugin-plugin</artifactId> | |||
| <artifactId>maven-plugin-report-plugin</artifactId> | |||
There was a problem hiding this comment.
I am not sure why there is no profile reporting in this project. IMHO this belongs there. WDYT @michael-o
There was a problem hiding this comment.
For me is ok ... even more I would be happy to remove reporting profile at all everywhere.
We always should execute all reporting plugins not only in special profile
There was a problem hiding this comment.
@kwin I move this to a profile for consistency reasons with others.
There was a problem hiding this comment.
For me is ok ... even more I would be happy to remove reporting profile at all everywhere.
We always should execute all reporting plugins not only in special profile
This is a separate discussion. The reason is likely computational overhead.
There was a problem hiding this comment.
I moved to a profile in bacee6d
kwin
force-pushed
the
bugfix/MNGSITE-540-fix-missing-reports-for-goals
branch
from
20e8ea8 to
db923dd
Compare
|
Will check later today |
maven-scm-plugin/pom.xml
Outdated
| @@ -228,7 +228,7 @@ | |||
| <plugins> | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-plugin-plugin</artifactId> | |||
| <artifactId>maven-plugin-report-plugin</artifactId> | |||
There was a problem hiding this comment.
@kwin I move this to a profile for consistency reasons with others.
maven-scm-plugin/pom.xml
Outdated
| @@ -228,7 +228,7 @@ | |||
| <plugins> | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-plugin-plugin</artifactId> | |||
| <artifactId>maven-plugin-report-plugin</artifactId> | |||
There was a problem hiding this comment.
For me is ok ... even more I would be happy to remove reporting profile at all everywhere.
We always should execute all reporting plugins not only in special profile
This is a separate discussion. The reason is likely computational overhead.
With https://issues.apache.org/jira/browse/MPLUGIN-423 the reporting mojo has been extracted in a dedicated plugin Encapsulate in "reporting" profile
kwin
force-pushed
the
bugfix/MNGSITE-540-fix-missing-reports-for-goals
branch
from
db923dd to
bacee6d
Compare
With https://issues.apache.org/jira/browse/MPLUGIN-423 the reporting mojo has been extracted in a dedicated plugin