TF_NER_POC: Make training configurable #38
Conversation
thygesen
force-pushed
the
cmd_args_config
branch
2 times, most recently
from
0aaae35 to
cee66cd
Compare
thygesen
force-pushed
the
cmd_args_config
branch
4 times, most recently
from
ba878fc to
40fb6d1
Compare
thygesen
force-pushed
the
cmd_args_config
branch
from
40fb6d1 to
06c1020
Compare
| return allowUNK; | ||
| } | ||
|
|
||
| public void setAllowUNK(boolean allowUNK) { |
There was a problem hiding this comment.
The setters should be private, if this was not set during training, it might not worker properly, we should anyway always have the UNK token, and not make it optional.
There was a problem hiding this comment.
I dont agree. The PredictionConfiguration is not read from the trained model. Therefore you need to able to set the values.
| } | ||
|
|
||
| public void setAllowNUM(boolean allowNUM) { | ||
| this.allowNUM = allowNUM; |
There was a problem hiding this comment.
This should be private, and only change during training time.
| return allowUNK; | ||
| } | ||
|
|
||
| public void setAllowUNK(boolean allowUNK) { |
There was a problem hiding this comment.
I dont agree. The PredictionConfiguration is not read from the trained model. Therefore you need to able to set the values.
thygesen
force-pushed
the
cmd_args_config
branch
from
06c1020 to
75d2ea1
Compare
| private final boolean allowUnk = true; | ||
| private boolean lowerCase = false; | ||
| private boolean allowUnk = true; | ||
| private boolean allowNum = false; | ||
|
|
||
| private final Pattern digitPattern = Pattern.compile("\\d+(,\\d+)*(\\.\\d+)?"); |
There was a problem hiding this comment.
This pattern can't be declared final any longer, as this PR introduces a setter for this, see below.
No description provided.