only replace xRef with corrected entries, if the original entry was n…

…ot valid
apache · Oct 5, 2021 · cc01382 · cc01382
1 parent 8604732
commit cc01382
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java b/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java
@@ -1159,6 +1159,7 @@ private boolean validateXrefOffsets(Map<COSObjectKey, Long> xrefOffset) throws I
             return true;
         }
         Map<COSObjectKey, COSObjectKey> correctedKeys = new HashMap<>();
+        Map<COSObjectKey, COSObjectKey> validKeys = new HashMap<>();
         for (Entry<COSObjectKey, Long> objectEntry : xrefOffset.entrySet())
         {
             COSObjectKey objectKey = objectEntry.getKey();
@@ -1178,13 +1179,18 @@ else if (foundObjectKey != objectKey)
                 {
                     // Generation was fixed - need to update map later, after iteration
                     correctedKeys.put(objectKey, foundObjectKey);
+                } else {
+                    validKeys.put(objectKey, foundObjectKey);
                 }
             }
         }
         for (Entry<COSObjectKey, COSObjectKey> correctedKeyEntry : correctedKeys.entrySet())
         {
-            xrefOffset.put(correctedKeyEntry.getValue(),
-                    xrefOffset.remove(correctedKeyEntry.getKey()));
+            if(!validKeys.containsKey(correctedKeyEntry.getValue())) {
+                // Only replacy entries, if the original entry does not point to a valid object
+                xrefOffset.put(correctedKeyEntry.getValue(),
+                        xrefOffset.remove(correctedKeyEntry.getKey()));
+            }
         }
         return true;
     }
@@ -1237,8 +1243,10 @@ private COSObjectKey findObjectKey(COSObjectKey objectKey, long offset) throws I
             // try to read the given object/generation number
             long foundObjectNumber = readObjectNumber();
             if(objectKey.getNumber() != foundObjectNumber){
+                System.out.println("found wrong object number. expected [" + objectKey.getNumber() +"] found ["+ foundObjectNumber + "]");
                 LOG.warn("found wrong object number. expected [" + objectKey.getNumber() +"] found ["+ foundObjectNumber + "]");
                 if(!isLenient) return null;
+                else objectKey = new COSObjectKey(foundObjectNumber, objectKey.getGeneration());
             }
 
             int genNumber = readGenerationNumber();