[fix][broker] Fix flaky test case - testClusterMigrationWithReplicationBacklog #20546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
reviewed
Jun 12, 2023
| // verify that the producer1 is now connected to migrated cluster "r2" since backlog is cleared. | ||
| retryStrategically((test) -> topic2.getProducers().size() == 2, 60, 1000); |
There was a problem hiding this comment.
So we can remove line-463
There was a problem hiding this comment.
No. Line 463 is assertion. Line 462 just does retries until the condition satisfies and exits after the specified retries are exhausted.
|
The pr had no activity for 30 days, mark with Stale label. |
lhotari
added
release/3.0.9
release/4.0.2
and removed
release/3.0.8
release/4.0.1
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix issue- 20375
Fix the flaky test case introduced by this pr - #19605
Modifications
Add retry block before asserting if the producer is connected to green cluster as this will provide enough time to the producer to reconnect to green cluster after the replication backlog is drained. The retry block will provide 60 secs time for the producer to reconnect checking at the periodic intervals of 500ms since the default max backoff time is 60 secs.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-complete