-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][function] Introduced protections against deserialization attacks #22723
base: master
Are you sure you want to change the base?
Conversation
@khac Please add the following content to your PR description and select a checkbox:
|
hey lhotari, Technoboy-, codelipenghui, gaoran10, congbobo184 and liangyepianzhou can you take a look? |
Great contribution! Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! It is a great catch. Leave a little comment.
</dependencies> | ||
</dependencyManagement> | ||
<properties> | ||
<versions.java-security-toolkit>1.1.3</versions.java-security-toolkit> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the properties in the parent pom file.
Motivation
This change hardens Java deserialization operations against attack. Even a simple operation like an object deserialization is an opportunity to yield control of your system to an attacker. In fact, without specific, non-default protections, any object deserialization call can lead to arbitrary code execution.
Modifications
I have added pixee java security toolkit as a dependency, and in pulsar functions in the the Serialization/ Deserialization file I have added
ObjectInputFilters.enableObjectFilterIfUnprotected
to the object input stream.Motivation
Modifications
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: