SOLR-16974: Global Circuit Breakers #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Next step would be to add some solr.xml parsing, say from a new |
janhoy
commented
Sep 13, 2023
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerRegistry.java
Show resolved
Hide resolved
janhoy
force-pushed
the
SOLR-16974-global-circuit-breakers
branch
from
22c2e25 to
2907ecf
Compare
janhoy
commented
Sep 23, 2023
Deregister global breaker after test
janhoy
commented
Sep 23, 2023
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java
Outdated
Show resolved
Hide resolved
janhoy
commented
Sep 26, 2023
| @@ -814,6 +815,7 @@ public Path getInstancePath() { | |||
| new Class<?>[] { | |||
| // DO NOT ADD THINGS TO THIS LIST -- ESPECIALLY THINGS THAT CAN BE CREATED DYNAMICALLY | |||
| // VIA RUNTIME APIS -- UNTIL CAREFULLY CONSIDERING THE ISSUES MENTIONED IN SOLR-8311 | |||
| CircuitBreaker.class, | |||
There was a problem hiding this comment.
Any objections to add CircuitBreaker to the list of SolrCoreAware classes? Solr's home grown IOC sucks but that's what we have...
|
I think this is ready for review |
cpoerschke
reviewed
Nov 7, 2023
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java
Outdated
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java
Outdated
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerRegistry.java
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerRegistry.java
Outdated
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerRegistry.java
Outdated
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java
Outdated
Show resolved
Hide resolved
…BreakerRegistry.java Co-authored-by: Christine Poerschke <[email protected]>
…BreakerRegistry.java Co-authored-by: Christine Poerschke <[email protected]>
cpoerschke
approved these changes
Nov 8, 2023
janhoy
added a commit
to janhoy/solr
that referenced
this pull request
Nov 8, 2023
Co-authored-by: Christine Poerschke <[email protected]> (cherry picked from commit e740123)
janhoy
added a commit
that referenced
this pull request
Nov 25, 2023
Co-authored-by: Christine Poerschke <[email protected]> (cherry picked from commit e740123)
nginthfs
pushed a commit
to cowpaths/fullstory-solr
that referenced
this pull request
Jun 11, 2024
Co-authored-by: Christine Poerschke <[email protected]>
nginthfs
pushed a commit
to cowpaths/fullstory-solr
that referenced
this pull request
Jul 1, 2024
Co-authored-by: Christine Poerschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16974
Proof-of-concept with static map of global breakers.