SOLR-14115: Allow bin/solr zk commands to have parity with zkcli.sh commands. #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em to the SolrCLI Zk subcommands
|
Discovered that we have some great unit testings for the ZkCLI.java, and we don't have them for bin/solr zk, so going to copy the over to a new unit test |
However, the compression state still needs to be dealt with...
Need to resolve testPutCompressed versus testGetCompressed...
this feels like we are going backwards on reducing complexity ;-(
|
Making progress... I know that I think I have |
github-actions
bot
added
the
documentation
…pressor However, I think the compression choice COULD be a builder option when creating SolrZkClient, which would simplify the methods and avoid duplication. Wanted to get POC up.
7 tasks
epugh
added a commit
that referenced
this pull request
Apr 29, 2024
…ommands. (#2298) Add updateacls, cluster, and linkconfig as standard Solr tools. Introduce some better testing of these relatively unknown tools. Keep zkcli.sh as is for the 9x branch of code. Some challenges around how we handle compression of state.json dealt with.
janhoy
reviewed
Dec 6, 2024
| @@ -1,5 +1,7 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| echo "WARNING: The zkcli.sh script has been deprecated in favour of the bin/solr equivalent commands." | |||
There was a problem hiding this comment.
This addition broke the solr-operator, see apache/solr-operator#720
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.