Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16403
Description
#1926 introduced unreliability into the DeleteShardTest by inadvertently removing the wait on observing the new Shard state. This could cause the test to fail depending on timings.
Solution
Correct the issue by using the class method to change the Shard state (as intended), instead of calling ShardTestUtil directly, restoring the wait on the state change being observed.
Tests
This is a test change. The test runs reliably once more.
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.