Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unreliable DeleteShardTest #2359

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Fix unreliable DeleteShardTest #2359

merged 1 commit into from
Mar 20, 2024

Conversation

pjmcarthur
Copy link
Contributor

https://issues.apache.org/jira/browse/SOLR-16403

Description

#1926 introduced unreliability into the DeleteShardTest by inadvertently removing the wait on observing the new Shard state. This could cause the test to fail depending on timings.

Solution

Correct the issue by using the class method to change the Shard state (as intended), instead of calling ShardTestUtil directly, restoring the wait on the state change being observed.

Tests

This is a test change. The test runs reliably once more.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@dsmiley dsmiley merged commit f56db50 into apache:main Mar 20, 2024
2 of 3 checks passed
dsmiley pushed a commit that referenced this pull request Mar 20, 2024
Simple mistake; test failed sometimes

Co-authored-by: Paul McArthur <[email protected]>
(cherry picked from commit f56db50)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants