-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-17583: Bring back documentation for Adding Custom Expressions #2903
Conversation
The section for adding Custom Expressions was removed in Solr 8.8. This change brings it back.
Thanks for PR. Have you tried to generate the doc? I'm not sure if the reference syntax hasn't changed from those times, and link might be broken. |
Build it myself. Link to javadoc works fine. Merging. I don't think it deserves CHANGES row. |
@cfeldmann please cherry-pick this commin to https://github.com/apache/solr/tree/branch_9x and make a PR. |
It can even be cherry picked to branch_9_7 for immediate visibility in the 9.7 guide. |
…pache#2903) The section for adding Custom Expressions was removed in Solr 8.8. This change brings it back. Co-authored-by: Christine Feldmann <[email protected]>
…pache#2903) The section for adding Custom Expressions was removed in Solr 8.8. This change brings it back. Co-authored-by: Christine Feldmann <[email protected]>
…2903) (#2904) The section for adding Custom Expressions was removed in Solr 8.8. This change brings it back. Co-authored-by: Christine Feldmann <[email protected]>
…2903) (#2905) The section for adding Custom Expressions was removed in Solr 8.8. This change brings it back. Co-authored-by: Christine Feldmann <[email protected]>
https://issues.apache.org/jira/browse/SOLR-17583
Description
The section for adding Custom Expressions was removed in Solr 8.8. This change brings it back.
Solution
I found the source for the Custom Expressions section in the 8.7 docs and copied It to the current streaming-expressions.adoc page. The Expressible interface has been moved into the solrj-streaming package since version 8.7 so I updated the link to this interface to point to the correct javadoc location.
Tests
I ran
./gradlew tidy updateLicenses check -x test
and then opened my local copy of the Reference Guide. I verified that I see the new text and that the link to the Expressible javadoc is working.Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.