Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17597: Fix CaffeineCache.put() ramBytes decrement #2917

Conversation

magibney
Copy link
Contributor

@magibney
Copy link
Contributor Author

This probably does not warrant a CHANGES.txt entry, since it doesn't impact any existing/default implementation or invocation of CaffeineCache.

NOTE: the second (V oldValue) arg to the private method CaffeineCache.recordRamBytes() is always null as now invoked, and could be removed. I will remove this unless anyone objects.

@magibney
Copy link
Contributor Author

This is a trivial change with no practical impact on the vast majority of users. I plan to merge this tomorrow, pending any feedback.

Copy link
Contributor

@dsmiley dsmiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah just merge

@magibney magibney merged commit a40826e into apache:main Dec 20, 2024
3 checks passed
magibney added a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants