Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17306: fix replication problem on follower restart #2918

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

ds-manzinger
Copy link
Contributor

@ds-manzinger ds-manzinger commented Dec 18, 2024

https://issues.apache.org/jira/browse/SOLR-17306

Same as #2873 -> but now against main branch

Description

If Leader has Replication disabled - do not delete Followers data on restart

Solution

Check if Leader Replication is enabled

Tests

Implemented Unit Tests, that check different restart scenarios. Enable Directory Storage for Replica, othwerwise tests will not work because memory is cleaned on restart

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@github-actions github-actions bot added the tests label Dec 18, 2024
@ds-manzinger
Copy link
Contributor Author

ds-manzinger commented Dec 18, 2024

@epugh Sorry for that new Pull Request. Sync with apache/solr broke my history

PR was automatically closed 😢

@epugh
Copy link
Contributor

epugh commented Dec 19, 2024

waiting for checks to complete and then will merge! let's hope my nemesis CHANGES.txt doesn't get me!

@epugh epugh merged commit 9cef6e3 into apache:main Dec 19, 2024
3 checks passed
epugh pushed a commit that referenced this pull request Dec 19, 2024
epugh pushed a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants