-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for adding custom tika configuration #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really nice patch @ahilmathew nice job! One minor suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally via k3d. LGTM.
Any thoughts @nddipiazza ?
@nddipiazza any feedback? Would be great to get this merged if possible. Thanks |
@ahilmathew even if it is commented out by default, I think we should add the |
@lewismc @nddipiazza I'm champing at the bit to to see this merged, xml configuration essential in Tika v2+ |
@ahilmathew please sync with |
@t-l-k understood 👍 |
@lewismc Thanks for the comments. I've updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ahilmathew please see minor comment
@lewismc - Updated now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thank you @ahilmathew really nice patch. |
Added support for custom tika configuration to be used in the helm chart via the
tikaConfig
key in thevalues.yaml
.This key is optional which when configured will create a
configMap
and then mounted astika-config.xml
into the running pod.