Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for adding custom tika configuration #15

Merged
merged 9 commits into from
Apr 8, 2024
Merged

Conversation

ahilmathew
Copy link
Contributor

Added support for custom tika configuration to be used in the helm chart via the tikaConfig key in the values.yaml.

This key is optional which when configured will create a configMap and then mounted as tika-config.xml into the running pod.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@lewismc lewismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice patch @ahilmathew nice job! One minor suggestion.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@lewismc lewismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally via k3d. LGTM.
Any thoughts @nddipiazza ?

@lewismc
Copy link
Member

lewismc commented Mar 26, 2024

@nddipiazza any feedback? Would be great to get this merged if possible. Thanks

@lewismc
Copy link
Member

lewismc commented Mar 30, 2024

@ahilmathew even if it is commented out by default, I think we should add the tikaConfig element to values.yaml.

@t-l-k
Copy link

t-l-k commented Apr 2, 2024

@lewismc @nddipiazza I'm champing at the bit to to see this merged, xml configuration essential in Tika v2+

@lewismc
Copy link
Member

lewismc commented Apr 4, 2024

@ahilmathew please sync with main branch and also include the default oncfiguration in values.yaml. Thank you

@lewismc
Copy link
Member

lewismc commented Apr 4, 2024

@t-l-k understood 👍

@ahilmathew
Copy link
Contributor Author

@lewismc Thanks for the comments. I've updated values.yaml to include the configuration from https://tika.apache.org/2.9.1/configuring.html. Let me know if there is a specific configuration you would like to be included as default.

Copy link
Member

@lewismc lewismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahilmathew please see minor comment

templates/configmap.yaml Show resolved Hide resolved
@ahilmathew
Copy link
Contributor Author

@lewismc - Updated now.

Copy link
Member

@lewismc lewismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lewismc lewismc merged commit 8278ff6 into apache:main Apr 8, 2024
1 check passed
@lewismc
Copy link
Member

lewismc commented Apr 8, 2024

Thank you @ahilmathew really nice patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants