Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for composer analyze failing in github action #349

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

divya-intelli
Copy link
Collaborator

@divya-intelli divya-intelli commented Jan 31, 2024

Closes #348
For now have added errorLevel as 'info' to skip RiskyTruthyFalsyComparison error while running composer analyze. Also upgraded vimeo/psalm version to latest as this error was adding in the latest release.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b561085) 87.71% compared to head (bd44488) 87.71%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                3.x     #349   +/-   ##
=========================================
  Coverage     87.71%   87.71%           
  Complexity     1751     1751           
=========================================
  Files           349      349           
  Lines          4713     4713           
=========================================
  Hits           4134     4134           
  Misses          579      579           
Flag Coverage Δ
unittests 87.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@divya-intelli divya-intelli merged commit f0b1790 into apigee:3.x Jan 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Composer analyze is failing in github action
2 participants