Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: base pipeline builder off alpine #768

Merged
merged 13 commits into from
Dec 20, 2024
Merged

Conversation

danistrebel
Copy link
Collaborator

@danistrebel danistrebel commented Dec 19, 2024

Description

What's changed, or what was fixed?

  • moved nightly-pipeline base image to alpine:3.21 (google/cloud-sdk:alpine uses 3.19 and wasn't compatible with some go tooling we use)
  • fix error handling in the common-shared flows
  • fix broken link in doc
  • added option to run selective projects only in PR flow to save time/resources
  • added icons for pass/fail in PR comment for better readability

Issues Fixed

  • Fixes #

Housekeeping

(please check all that apply [x], do not edit the text)

  • I have run all the tests locally and they all pass.
  • I have followed the relevant style guide for my changes.

Full Repo Validation Required

(please check all that apply [x], do not edit the text)

  • PR requires full pipeline run (Run for changes only by default).
  • Test following projects (comma separated list): references/proxy-template,references/oidc-mock,references/identity-facade

CC: @apigee-devrel-reviewers

@danistrebel danistrebel requested a review from seymen as a code owner December 19, 2024 11:06
@danistrebel
Copy link
Collaborator Author

/gcbrun

Copy link

github-actions bot commented Dec 19, 2024

Mega-Linter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.09s
⚠️ BASH bash-exec 105 1 12.87s
✅ BASH shellcheck 105 0 16.47s
⚠️ BASH shfmt 105 93 12.87s
⚠️ COPYPASTE jscpd yes 63 6.02s
✅ CREDENTIALS secretlint yes no 4.29s
✅ DOCKERFILE dockerfilelint 9 0 3.32s
✅ DOCKERFILE hadolint 9 0 1.86s
✅ GIT git_diff yes no 0.12s
✅ GO golangci-lint 2 0 8.55s
✅ GO revive 2 0 0.33s
✅ JAVA checkstyle 6 0 12.59s
✅ JAVASCRIPT eslint 94 0 2.21s
✅ JSON eslint-plugin-jsonc 65 0 8.02s
✅ JSON jsonlint 65 0 31.76s
⚠️ JSON prettier 65 1 6.49s
✅ JSON v8r 65 0 293.72s
⚠️ MARKDOWN markdownlint 51 171 1.16s
✅ MARKDOWN markdown-link-check 51 0 134.63s
⚠️ MARKDOWN markdown-table-formatter 51 1 0.4s
✅ OPENAPI spectral 12 0 33.99s
✅ PROTOBUF protolint 1 0 0.14s
✅ PYTHON bandit 7 0 1.1s
⚠️ PYTHON black 7 1 2.03s
✅ PYTHON flake8 7 0 1.15s
⚠️ PYTHON isort 7 7 0.43s
⚠️ PYTHON mypy 7 1 0.45s
✅ PYTHON pylint 7 0 8.07s
⚠️ SPELL cspell 830 1468 39.9s
⚠️ SPELL misspell 830 1 0.44s
✅ XML xmllint 420 0 0.19s
⚠️ YAML prettier 35 1 2.95s
✅ YAML v8r 35 0 100.56s
✅ YAML yamllint 35 0 1.2s

See errors details in artifact Mega-Linter reports on GitHub Action page

You could have same capabilities but better runtime performances if you request a new Mega-Linter flavor.

@danistrebel
Copy link
Collaborator Author

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
/workspace/tools/apigee-x-trial-provision fail 31s
/workspace/references/auth-schemes pass 75s
/workspace/references/cicd-pipeline fail 195s
/workspace/references/cicd-sharedflow-pipeline pass 197s
/workspace/references/cloud-logging-shared-flow pass 157s
/workspace/references/cloud-run pass 227s
/workspace/references/common-shared-flows pass 0s
/workspace/references/data-api pass 81s
/workspace/references/data-converters-shared-flow pass 95s
/workspace/references/dutch-healthcare pass 262s
/workspace/references/firestore-facade pass 181s
/workspace/references/gcp-sa-auth-shared-flow pass 154s
/workspace/references/identity-facade fail 315s
/workspace/references/java-callout pass 107s
/workspace/tools/hybrid-quickstart pass 2078s
/workspace/references/js-callout pass 88s
/workspace/references/oauth-admin-api pass 91s
/workspace/references/oidc-mock fail 254s
/workspace/references/openapi-mock pass 70s
/workspace/references/product-recommendations pass 282s
/workspace/references/proxy-template fail 85s
/workspace/references/recaptcha-enterprise pass 124s
/workspace/references/southbound-mtls pass 120s
/workspace/references/threat-protect pass 79s
/workspace/labs/bdd-proxy-development pass 0s
/workspace/labs/best-practices-hackathon pass 0s
/workspace/labs/eventarc-apihub pass 0s
/workspace/labs/idp-okta-integration pass 0s
/workspace/tools/apigee-envoy-quickstart fail 22s
/workspace/tools/apigee-openlegacy pass 0s
/workspace/tools/apigee-sackmesser fail 0s
/workspace/tools/decrypt-hybrid-assets pass 0s
/workspace/tools/endpoints-oas-importer pass 158s
/workspace/tools/grpc-http-gateway-generator fail 21s
/workspace/tools/oas-apigee-mock pass 31s
/workspace/tools/pipeline-linter pass 0s
/workspace/tools/pipeline-runner pass 0s
/workspace/tools/proxy-endpoint-unifier pass 6s
/workspace/tools/sf-dependency-list pass 1s
/workspace/tools/target-server-validator pass 124s
TOTAL PIPELINE pass 3602s

View details in Cloud Build (permission required)

Commit version: e1c307e

@danistrebel
Copy link
Collaborator Author

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
/workspace/tools/apigee-x-trial-provision fail 31s
/workspace/references/auth-schemes pass 98s
/workspace/references/cicd-pipeline pass 429s
/workspace/references/cicd-sharedflow-pipeline pass 201s
/workspace/references/cloud-logging-shared-flow pass 158s
/workspace/references/cloud-run pass 172s
/workspace/references/common-shared-flows pass 0s
/workspace/references/data-api pass 80s
/workspace/references/data-converters-shared-flow pass 91s
/workspace/references/dutch-healthcare pass 271s
/workspace/references/firestore-facade pass 177s
/workspace/references/gcp-sa-auth-shared-flow pass 183s
/workspace/tools/hybrid-quickstart pass 1932s
/workspace/references/identity-facade fail 314s
/workspace/references/java-callout pass 109s
/workspace/references/js-callout pass 118s
/workspace/references/oauth-admin-api pass 85s
/workspace/references/oidc-mock fail 311s
/workspace/references/openapi-mock pass 79s
/workspace/references/product-recommendations pass 220s
/workspace/references/proxy-template fail 72s
/workspace/references/recaptcha-enterprise pass 140s
/workspace/references/southbound-mtls pass 106s
/workspace/references/threat-protect pass 73s
/workspace/labs/bdd-proxy-development pass 0s
/workspace/labs/best-practices-hackathon pass 0s
/workspace/labs/eventarc-apihub pass 0s
/workspace/labs/idp-okta-integration pass 0s
/workspace/tools/apigee-envoy-quickstart pass 367s
/workspace/tools/apigee-openlegacy pass 0s
/workspace/tools/apigee-sackmesser pass 432s
/workspace/tools/decrypt-hybrid-assets pass 0s
/workspace/tools/endpoints-oas-importer pass 128s
/workspace/tools/grpc-http-gateway-generator pass 145s
/workspace/tools/oas-apigee-mock pass 26s
/workspace/tools/pipeline-linter pass 0s
/workspace/tools/pipeline-runner pass 0s
/workspace/tools/proxy-endpoint-unifier pass 7s
/workspace/tools/sf-dependency-list pass 1s
/workspace/tools/target-server-validator pass 147s
TOTAL PIPELINE pass 4740s

View details in Cloud Build (permission required)

Commit version: a4c4f8d

@danistrebel
Copy link
Collaborator Author

/gcbrun

@danistrebel danistrebel force-pushed the feature/fix-go-pipeline branch from a827067 to 506aebc Compare December 20, 2024 07:59
@danistrebel
Copy link
Collaborator Author

/gcbrun

@danistrebel danistrebel force-pushed the feature/fix-go-pipeline branch from 506aebc to b19c10f Compare December 20, 2024 08:23
@danistrebel
Copy link
Collaborator Author

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
references/cicd-pipeline pass 429s
tools/apigee-sackmesser pass 365s
TOTAL PIPELINE pass 794s

View details in Cloud Build (permission required)

Commit version: b19c10f

@danistrebel danistrebel force-pushed the feature/fix-go-pipeline branch from b19c10f to 112238f Compare December 20, 2024 08:47
@danistrebel
Copy link
Collaborator Author

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
references/cicd-pipeline 523s
references/cicd-pipeline 523s
tools/apigee-sackmesser 374s
tools/apigee-sackmesser 374s
references/identity-facade 316s
references/identity-facade 316s
references/proxy-template 82s
references/proxy-template 82s
references/oidc-mock 313s
references/oidc-mock 313s
tools/apigee-envoy-quickstart 357s
tools/apigee-envoy-quickstart 357s
tools/grpc-http-gateway-generator 140s
tools/grpc-http-gateway-generator 140s
TOTAL PIPELINE 2105s
TOTAL PIPELINE 2105s

View details in Cloud Build (permission required)

Commit version: 112238f

@danistrebel
Copy link
Collaborator Author

/gcbrun

@apigee-devrel-bot
Copy link

apigee-devrel-bot commented Dec 20, 2024

Pipeline Report

Pipeline Result Elapsed Wall Time
references/proxy-template; 404s
references/oidc-mock 315s
references/identity-facade 313s
TOTAL PIPELINE 1032s

View details in Cloud Build (permission required)

Commit version: 21d0837

@danistrebel
Copy link
Collaborator Author

/gcbrun

@danistrebel
Copy link
Collaborator Author

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
references/proxy-template 329s
references/oidc-mock 254s
references/identity-facade 312s
TOTAL PIPELINE 895s

View details in Cloud Build (permission required)

Commit version: 9a3a12b

@danistrebel
Copy link
Collaborator Author

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
references/proxy-template 316s
references/oidc-mock 21s
references/identity-facade 276s
TOTAL PIPELINE 613s

View details in Cloud Build (permission required)

Commit version: 6c3ada5

@danistrebel danistrebel merged commit 6e03cf6 into main Dec 20, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants