[CI Trigger] WIP/pikachu-ci-trigger (with rubocop fixes and GHA fixup) #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rop JRuby Update the GH Actions workflow to match our current supported targets for circa Ronn-NG 0.10.1. * Drop old unsupported rubies. And the whole "unsupported" switch and continue-on-error thing; they were only needed for unsupported ruby versions (I think). * Drop JRuby. I don't plan to support it at all. * Add macOS. * Use '-latest' instead of a fixed version for the OSes. * Drop old Ruby versions (prior to 2.7, which is our new minimum supported Ruby). * Add ruby 3.2, 3.3, and "head". * Bump versions of GH action definitions (uses) and use major-version-only specifications (recommended by the doco for the ruby/setup-ruby action. * Run rubocop with ruby 3.2 instead of 2.7. * Drop the turned-off GH Pages action. I won't want to update gh pages based on a git push like this. I prefer manual publishing for tighter version control relate to releases. And publishing regenerates the man pages; I don't want the timestamp on those to be from a CI runner. I want manual control and review of all published documentation.
We need nokogiri >= 1.14.3 to get the right behavior for namespace-looking tag names with ":" in them, and nokogiri 1.14.3 requires ruby >= 2.7. Ruby 2.7+ is all I want to work and test on for other reasons, anyway. Users who really want to deploy on older Rubies can edit the gemspec file. But if I'm being honest, really my main reason for doing this is to make Rubocopy happy.
|
Cool, all checks passed. Closing this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only exists to trigger a run of GH Actions against the rubocop fixups and GHA revisions on the
WIP/pikachu-ci-triggerbranch, underlets-go-pikachu-0.10. It will not be merged.