Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I have added logic to lookup os.environ 'URL_PREFIX' if exists use it instead of the DEFAULT_PREFIX #108

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

I have added logic to lookup os.environ 'URL_PREFIX' if exists use it instead of the DEFAULT_PREFIX #108

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dbe1cf2
Update app.py replace url_prefix '/cnr' with '/'
myselfram Jun 15, 2023
f7bdfd7
Merge pull request #1 from myselfram/rs-replace-url-prefix-cnr
myselfram Jun 15, 2023
189bbad
Reversed app.py changes and edited client.py
myselfram Jun 22, 2023
3ca4973
Update client.py
myselfram Jun 22, 2023
a217a2c
Update client.py
myselfram Jun 22, 2023
dc1a62b
Update client.py
myselfram Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions appr/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ def _configure_endpoint(self, endpoint):
else:
scheme = "https://"
endpoint = scheme + endpoint
if 'URL_PREFIX' in os.environ:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please name it: APPR_URL_PREFIX and it should be good to merge

return urlparse(endpoint + os.environ['URL_PREFIX'])
return urlparse(endpoint + DEFAULT_PREFIX)

@property
Expand Down