Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Added test for user plugin #31

Closed
wants to merge 3 commits into from

Conversation

harsh-2711
Copy link

@harsh-2711 harsh-2711 commented Sep 11, 2019

What does this do / why do we need it?

Adds tests for user plugin methods

What should your reviewer look out for in this PR?

Added tests for methods in service.go file in dao_test.go

Do you need help or clarification on anything?

No

Which issue(s) does this PR fix?

Fixes: #19

@harsh-2711 harsh-2711 self-assigned this Sep 11, 2019
@harsh-2711 harsh-2711 added the help wanted Extra attention is needed label Sep 11, 2019
@harsh-2711
Copy link
Author

@jeet-parekh I want some help for writing tests of getRawUser and getRawUsers methods. I am getting the same error as in PR #25 i.e. json: cannot unmarshal number into Go struct field SearchHits.hits.total of type elastic.TotalHits

@jeet-parekh
Copy link

@harsh-2711, let's keep the discussion at PR #25.

@harsh-2711 harsh-2711 changed the title [WIP] test: Added test for user plugin test: Added test for user plugin Sep 17, 2019
@harsh-2711
Copy link
Author

@bietkul @jeet-parekh Can you help me out with methods in middleware.go?

@siddharthlatest
Copy link
Member

closing this, as we have moved to using end-to-end tests instead of mock tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants