feature[iOS]: Add support to live-activity notifications #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GonzaloAvilez
changed the title
…f apns2 related to live activity
|
@appleboy I would like to know what do you think about this PR proposal, it make sense to you support live activity notifications ? |
appleboy
approved these changes
Aug 17, 2024
|
@GonzaloAvilez Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOAL:
Additional NOTES: Recently it was updated APNS2 with similar changes. Waiting new release of that library sideshow/apns2. new relase library -> https://github.com/sideshow/apns2/releases/tag/v0.24.0
PR that support live activity in APNS2 -> Live Activity support added (revised and expanded) sideshow/apns2#219
(My PR version to support live activity in APNS2) -> Add iOS 16 support for Live activity iOS notifications sideshow/apns2#223
Updates in Readme iOS 16 + live activity feature
Update go.mod and go.sum to for APNS2 0.24.0 library
TESTS
Test code coverage
Manual testing with curl POST events using GonzaloAvilez/apns2#1 with current suggested changes.
Test code coverage after using newest version of APNS2 within go modules:
