This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Retry Util -> Busy Retry Util #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irq0
force-pushed
the
pr/retry-transactions
branch
3 times, most recently
from
48a9921 to
0ac94a7
Compare
added 2 commits
October 13, 2023 13:12
Return true if ec is an error signaling a busy database and the transaction that failed is safe to retry. Signed-off-by: Marcel Lauhoff <[email protected]>
Rename to RetrySQLiteBusy. Change behavior to:
- rethrow non-busy errors immediately. We no longer retry errors that
we should not like constraint violations
- abort on critical errors (e.g db corruption)
Signed-off-by: Marcel Lauhoff <[email protected]>
irq0
force-pushed
the
pr/retry-transactions
branch
from
0ac94a7 to
4622f24
Compare
jecluis
approved these changes
Oct 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change SQLite transaction retry util into a busy retry util that only
retries database busy conditions not constraint errors
Related issue: https://github.com/aquarist-labs/s3gw/issues/645
Checklist