Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Retry add_delete_marker_transact #248

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

irq0
Copy link
Member

@irq0 irq0 commented Nov 16, 2023

  • rgw/sfs: Refactor add_delete_marker_transact
  • rgw/sfs: Retry delete_version_and_get_previous_transact

Fixes: https://github.com/aquarist-labs/s3gw/issues/645

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)

Marcel Lauhoff added 2 commits November 16, 2023 13:21
Make added the return value. Make id an optional out parameter as it
is only used by unit tests.

Signed-off-by: Marcel Lauhoff <[email protected]>
@irq0 irq0 requested a review from 0xavi0 November 16, 2023 14:34
@irq0 irq0 added the area/rgw-sfs RGW & SFS related label Nov 16, 2023
@irq0 irq0 self-assigned this Nov 16, 2023
@irq0 irq0 added this to the v0.23.0 milestone Nov 16, 2023
@jecluis jecluis modified the milestones: v0.23.0, v0.24.0 Nov 26, 2023
Copy link

@0xavi0 0xavi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m

@irq0 irq0 merged commit d08bc76 into aquarist-labs:s3gw Nov 28, 2023
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/rgw-sfs RGW & SFS related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Retry Read-Then-Write Transactions (Epic)
3 participants