Added empty actual value and expected value and non-empty flagName test

[arjunkhunti-crest]

• Close kube-bench checks are failing in case of the expected value and actual value is empty string. #1515

Kube-bench checks fail when the flagVal and compareValue are empty strings and flagName is given. To resolve this, I have updated the code where flagName is assigned to the compareVal and added a test for the same.

Expected Outcome

{label: “empty - val”, op: “eq”, flagVal: “”, compareValue: “”, expectedResultPattern: “‘flagName’ is equal to ‘’“, testResult: true, flagName: “flagName”}

Actual Outcome

{label: "empty - val", op: "eq", flagVal: "", compareValue: "", expectedResultPattern: "'flagName' is equal to ''", testResult: false, flagName: "flagName"}

[CLAassistant]

All committers have signed the CLA.

[mozillazg]

@arjunkhunti-crest Could you please fix the e2e test? Thanks.

[mozillazg]

IMHO, adding a workaround code (!strings.Contains(t.Flag, ":")) is not a good idea.

How about adding a new op like isempty instead of changing the eq op for your cases to support empty value?

[arjunkhunti-crest]

I'm not familiar with the process of adding a new operation, and I'm thinking about closing this pull request. I'll communicate this process in the corresponding issue to encourage others to contribute instead.

[arjunkhunti-crest]

As the suggested approach is different as implemented in this PR. Hence closing this PR.