Fix CGO_LDFLAGS*
#434
Merged
Fix CGO_LDFLAGS*
#434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For static build, get pc info from the freshly built libbpf.a instead of the system one. For dynamic build, set only the required ldflags for the system libbpf.
geyslan
force-pushed
the
fix-pkg-conf
branch
2 times, most recently
from
63c7b91 to
ca439ef
Compare
libzstd may be a dependency on libelf, which is a dependency on libbpf.
bobrik
reviewed
May 28, 2024
| @@ -20,7 +20,7 @@ runs: | |||
| sudo apt-get install --yes pkgconf | |||
| sudo apt-get install --yes llvm-12 clang-12 | |||
| sudo apt-get install --yes clang-format-12 | |||
| sudo apt-get install --yes zlib1g-dev libelf-dev | |||
| sudo apt-get install --yes libelf-dev libzstd-dev zlib1g-dev | |||
There was a problem hiding this comment.
I think you only really need libelf-dev, the rest is automatically pulled in:
There was a problem hiding this comment.
It's indeed. In fact, it could just be the main libbpf-dev, but it might be good to have them listed so that users from different environments (even tarball ones) can take a look at what is needed. @rscampos FYI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #429
commit 56601b4
commit 85ef759