feat: wrapper creation for libbpf_probe_bpf_helper #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rscampos
force-pushed
the
feat_probe_func_support
branch
from
4299289 to
558440f
Compare
|
With this PR #445 isn't completely true. |
yanivagman
reviewed
Jul 2, 2024
libbpfgo.go
Outdated
| @@ -96,6 +98,15 @@ func BPFMapTypeIsSupported(mapType MapType) (bool, error) { | |||
| return supportedC == 1, nil | |||
| } | |||
|
|
|||
| func BPFFuncTypeIsSupported(progType BPFProgType, funcId helpers.BPFFunc) (bool, error) { | |||
There was a problem hiding this comment.
For clarity, I suggest renaming to BPFHelperIsSupported
geyslan
previously approved these changes
Jul 2, 2024
There was a problem hiding this comment.
LGTM.
Please check https://github.com/aquasecurity/libbpfgo/pull/446/files#r1661926644. 👍🏼
rscampos
force-pushed
the
feat_probe_func_support
branch
from
558440f to
866aefe
Compare
geyslan
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the wrapper
BPFFuncTypeIsSupportedaroundlibbpf_probe_bpf_helperin order to check if bpf helper is available.It's necessary to give the bpf type and the function ID in order to know if it's supported.