Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add routeType attribute & logic to attempt static routes before parameterized routes #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

naqll
Copy link

@naqll naqll commented Jun 4, 2021

Issue can be found here.

A WIP POC to attempt static routes before those containing a parameter. This would allow overlapping routes to function as intended.
Example:

  • GET /users/:userid
  • GET /users/history

Copy link
Contributor

@ido50 ido50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thank you for this contribution to the project. Can you please update the unit tests after this change? They are now failing.

Thanks again.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants