Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning #689

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Cleaning #689

merged 7 commits into from
Dec 18, 2024

Conversation

camillebrianceau
Copy link
Collaborator

@camillebrianceau camillebrianceau commented Dec 18, 2024 •
edited
Loading

In this PR:

  • Renamed the dataset module to data.
  • Updated make_split and make_fold to accept pd.DataFrame as input data.
  • Updated __init__.py files and the API module.
  • Added a first DRAFT for ClinicaDLModel and Trainer: nothing needs to be kept in the future. For now, it just helps me see things a bit more clearly.
  • Removed commandline/module_options and config/config

@thibaultdvx thibaultdvx marked this pull request as ready for review December 18, 2024 14:33
@camillebrianceau camillebrianceau merged commit dc3443e into aramis-lab:clinicadl_v2 Dec 18, 2024
10 checks passed
@camillebrianceau camillebrianceau deleted the cb_prepare_train branch December 18, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibaultdvx thibaultdvx Awaiting requested review from thibaultdvx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camillebrianceau @thibaultdvx